feat: Do not create VM if system or bootstrap disks are marked for deletion #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to make decisions based on some of the information.
…only Refactor further; add unit tests with mocks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## jira/NCN-101014-refactor-get-image #492 +/- ##
======================================================================
- Coverage 34.70% 34.50% -0.21%
======================================================================
Files 18 18
Lines 2239 2252 +13
======================================================================
Hits 777 777
- Misses 1442 1455 +13
Partials 20 20 ☔ View full report in Codecov by Sentry. |
… for deletion Do not export function
thunderboltsid
approved these changes
Dec 13, 2024
dlipovetsky
force-pushed
the
jira/NCN-101014-refactor-get-image
branch
from
84229e6 to
26b934b
Compare
adiantum
reviewed
Jan 24, 2025
| // Returns an error if no image has the UUID, if no image has the name, or more than one image has the name. | ||
| func GetImageByNameOrUUID(ctx context.Context, client *prismclientv3.Client, image infrav1.NutanixResourceIdentifier) (*prismclientv3.ImageIntentResponse, error) { | ||
| switch { | ||
| case image.UUID != nil: |
There was a problem hiding this comment.
Here we have full NutanixResourceIdentifier, why don't we check that Type == NutanixIdentifierUUID.
Maybe we can even create a func isUuid() bool and func isName() bool for NutanixResourceIdentifier?
| foundImageUUID = *imageIntentResponse.Metadata.UUID | ||
| } else { // else search by name | ||
| return resp, nil | ||
| case image.Name != nil: |
| if foundImageUUID == "" { | ||
| return "", fmt.Errorf("failed to retrieve image by name or uuid. Verify input parameters") | ||
|
|
||
| switch { |
There was a problem hiding this comment.
Do we really need nested switch here?
| return foundImageUUID, nil | ||
| } | ||
|
|
||
| func imageMarkedForDeletion(image *prismclientv3.ImageIntentResponse) bool { |
There was a problem hiding this comment.
Are we going to use this helper function only in controllers package?
| imageIntentResponse, err := client.V3.GetImage(ctx, *imageUUID) | ||
| // GetImageByNameOrUUID returns an image. If no UUID is provided, returns the unique image with the name. | ||
| // Returns an error if no image has the UUID, if no image has the name, or more than one image has the name. | ||
| func GetImageByNameOrUUID(ctx context.Context, client *prismclientv3.Client, image infrav1.NutanixResourceIdentifier) (*prismclientv3.ImageIntentResponse, error) { |
There was a problem hiding this comment.
Why not just GetImage or GetImageByIdentifier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, if we create the VM and any of disk images are being deleted, the create task never completes, and end up waiting for task indefinitely. (We stop waiting only when the root reconcile context is cancelled, and I believe controller-runtime cancels that context only when the manager is stopped, i.e., if the process is gracefully terminated).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # https://jira.nutanix.com/browse/NCN-101014
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
Special notes for your reviewer:
Stacked on #489
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: