-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds cluster's ownerref on cilium helm values source object #1034
Conversation
fe41af7
to
0db9b0f
Compare
a02aeab
to
b0abe98
Compare
b0abe98
to
6d1e98d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other then one nit code suggestion.
Also we should add e2e tests for checking owner reference. https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/test/e2e/quick_start_test.go#L176
Needed to rebase to not break the build 498a27f |
🤖 I have created a release *beep* *boop* --- ## 0.26.0 (2025-02-05) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: adds new field for helm values input for cilium CNI by @manoj-nutanix in #1011 * feat: implementation for user defined configmap for cilium addon in cluster creation by @manoj-nutanix in #1033 * feat: update CAPI to v1.9.3 by @dkoshkin in #1010 * feat: adds cluster's ownerref on cilium helm values source object by @manoj-nutanix in #1034 ### Fixes 🔧 * fix: correctly copy Helm charts in init container by @dkoshkin in #1018 * fix: Use mindthegap v1.17.0 for the helm-repository container by @dlipovetsky in #1024 * fix: use republished COSI controller image by @dkoshkin in #1022 ### Other Changes * test: wait for COSI controller to be ready by @dkoshkin in #1014 * refactor: Remove api module dependency from common module by @jimmidyson in #1019 **Full Changelog**: v0.25.0...v0.26.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dimitri Koshkin <[email protected]>
|
What problem does this PR solve?:
Adds cluster's ownerref on cilium helm values source object so users won't have to explicitly need to add
clusterctl.cluster.x-k8s.io/move: ""
labelWhich issue(s) this PR fixes:
Fixes #
NCN-105148
How Has This Been Tested?:
Special notes for your reviewer: