Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCN-102850: Address the comments to put the HR behind a flux kustomization #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnliu25
Copy link
Contributor

@johnliu25 johnliu25 commented Oct 9, 2024

incorporate review comments from Grace Do #2 (review)

can do this in a follow up but I think we should put the HR behind a flux kustomization.
e.g. https://github.com/mesosphere/kommander-applications/blob/main/services/kube-prometheus-stack/60.4.1/helmrelease.yaml and HR moved into the dir the flux kust is pointing to https://github.com/mesosphere/kommander-applications/blob/main/services/kube-prometheus-stack/60.4.1/helmrelease/kube-prometheus-stack.yaml

@johnliu25 johnliu25 changed the title Address the comments to put the HR behind a flux kustomization NCN-102850: Address the comments to put the HR behind a flux kustomization Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant