Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue 358 #6

Merged
merged 5 commits into from
Jul 20, 2024
Merged

resolve issue 358 #6

merged 5 commits into from
Jul 20, 2024

Conversation

d4rkstar
Copy link

Should resolve nuvolaris/nuvolaris#358.

Runtimes are referenced in a variable called RUNTIMES.

So now is possible to do:

  1. specific language tagging and building
$ task image-tag RT=php
3.1.0-mastrogpt-php.2405170025
$ task build
Build php
[....]

The build will check for specific language in tag.

  1. generic tagging
$ task image-tag 
3.1.0-mastrogpt.2405170026
$ task build
==> BUILDING RUNTIMES golang,nodejs,php,python
[....]

when building, all runtimes in RUNTIMES variable are build in sequence.

Is possible to build specific runtimes to build this way:

$ task build RUNTIMES=golang,nodejs
==> BUILDING RUNTIMES golang,nodejs
[....]

@sciabarracom
Copy link

I was expeting also a change in the .github/workflow

@d4rkstar
Copy link
Author

d4rkstar commented May 17, 2024

Anyway: is the change in taskfile satisfactory?

@d4rkstar
Copy link
Author

Hello @sciabarracom, i splitted tasks for tag and build-and-push for each language. Let me know if this is ok or other changes are required.

@francescotimperi francescotimperi merged commit a648bda into nuvolaris:main Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor the build to build only runtimes for a single language
3 participants