Allow Laravel 12 #2665
Draft
Allow Laravel 12 #2665
+43
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
laravel-12
branch
2 times, most recently
from
911d7e3 to
ed42b1d
Compare
|
This is shaking out some nasty phpstan stuff, a small part is probably a bug on their side (for php 8.4; phpstan/phpstan-src#3855) but others seems to be related to larastan maybe not correctly detecting the testing mixing. Not sure how to fix this. Tests are passing so it's all working but it looks like phpstan/larastan might not understand some stuff all of a sudden. Quick search on both repo's did not yield any red flags. It might be on their side since only the "highest" dependency phpstan runs are failing (and 8.4 runs because of linked bug). Appreciate a quick look @spawnia since you might know what is going on here or maybe we should just have a little patience and this will resolve itself in a few days 🫣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow Laravel 12 and adjust tests and dependencies where needed.
There are some interesting things.
dms/phpunit-arraysubset-assertsdependency is not yet out for the phpunit we need for L12 and thus I've included the fork with the compatible PR. Since it's adevonly dependency this might be fine for now but should be reverted in the future. It does allow us to move forward at least.laravel/scoutversions since Scout doesn't update its version every time Laravel does, this was probably done in error in previous Laravel version updates.unset.possiblyHookedPropertyphpstan errors is a bug on their side, should be fixed soon-ish: Fix unsetting array item triggers unset.possiblyHookedProperty phpstan/phpstan-src#3855Breaking changes
None. Laravel 12 is also a super simple release for us from what it seems (in the BC department at least).