fix: don't forward error from decodeURI to next middleware #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forwarding error from `decodeuRI` further to the error middleware and subsequently triggering 500 response, just ignore it. Ignoring the error will likely crash in Nuxt later anyway but that is better as: - This package won't get the blame when error shows up locally or in production - Error triggered within Nuxt doesn't trigger 500 but 400 response which is better as this is input error rather than server error.
rchl
force-pushed
the
fix/dont-error-on-invalid-uri
branch
from
74b5148
to
a0b7b6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 37 37
Branches 8 8
=========================================
Hits 37 37
Continue to review full report at Codecov.
|
|
No one in here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forwarding error from
decodeURIfurther to theerror middleware and subsequently triggering 500 response, just ignore it.
Ignoring the error will likely crash in Nuxt later anyway but that
is better as:
which is better as this is input error rather than server error.