-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SelectMenu): use by
prop to compare objects for selected values & add support for dot notation in value-attribute
#2228
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1142db1
fix(SelectMenu): use `by` prop to compare objects for selected values
cernymatej 119c3df
fix(SelectMenu): add modelValue type
cernymatej 647dbeb
feat(SelectMenu): handle nested `valueAttribute` comparison using theβ¦
cernymatej 56d9a91
Merge branch 'dev' into fix-selectmenu-by-prop
cernymatej 6694fae
style(select-menu): fix indentation
cernymatej 3aedd10
Merge remote-tracking branch 'origin/fix-selectmenu-by-prop' into fixβ¦
cernymatej 70866d1
fix(select-menu): add support for dot notation in value-attribute
cernymatej b6a65e7
fix(select-menu): update label handling
cernymatej 792a5ea
Merge branch 'dev' into fix-selectmenu-by-prop
cernymatej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjamincanac Since the
selected
computed proeprty uses thecomputedAsync
options
Β to get the possible values, I initialized it toprops.options
Β so that it isn't empty during the initial render of the component to prevent a flash.However, now that I'm thinking about it, shouldn't we just use
props.options
directly in theselected
Β computed, instead ofoptions
- since we don't want to compare the model values with only the search results, but rather the whole options?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
options
because that's what was used previously, however, unless I'm missing something, I think thatprops.options
should have been used there as well:Though this only affects things if someone uses asynchronous search.