Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NavigationMenu): handle children on vertical orientation #2384

Merged
merged 14 commits into from
Oct 22, 2024

Conversation

sandros94
Copy link
Collaborator

@sandros94 sandros94 commented Oct 15, 2024

πŸ”— Linked issue

Resolves #2136

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Properly handle children on vertical orientation.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 self-assigned this Oct 15, 2024
@sandros94 sandros94 added enhancement New feature or request v3 #1289 labels Oct 15, 2024
@sandros94
Copy link
Collaborator Author

sandros94 commented Oct 15, 2024

Recording.2024-10-15.125348.mp4

A few things needs to be addressed:

  1. width jumps quite a bit (there isn't much we could do, other then defining the size beforehand)
  2. I'm failing to rotate the arrow icon (πŸ˜…)
  3. missing v-bind="contentProps" for the vertical content (should I add a Primitive?)

@benjamincanac benjamincanac changed the title fix(NavigationMenu): handle children on vertical orientation feat(NavigationMenu): handle children on vertical orientation Oct 18, 2024
Copy link

pkg-pr-new bot commented Oct 22, 2024

pnpm add https://pkg.pr.new/@nuxt/ui@2384

commit: 54838f8

@benjamincanac benjamincanac marked this pull request as ready for review October 22, 2024 20:29
@benjamincanac benjamincanac merged commit 34bddd4 into nuxt:v3 Oct 22, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @sandros94! 😊

@sandros94
Copy link
Collaborator Author

Thanks @sandros94! 😊

Thank you for all the help!

@sandros94 sandros94 deleted the nav-menu-vertical branch November 14, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants