Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): handle dot nation with by prop #2413

Merged
merged 11 commits into from
Oct 19, 2024
Merged

fix(Table): handle dot nation with by prop #2413

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e50f8bb
Merge branch 'dev' of github.com-rdjanuar:nuxt/ui into dev
rdjanuar Oct 17, 2024
8c38759
fix: conflict
rdjanuar Oct 18, 2024
0561109
Merge branch 'dev' of github.com-rdjanuar:nuxt/ui into dev
rdjanuar Oct 18, 2024
07a1767
feat(Table): add ability to compare nested field
rdjanuar Oct 18, 2024
1d0df99
fix: missing commit
rdjanuar Oct 18, 2024
b96c09f
fix: update accesor function
rdjanuar Oct 18, 2024
de36aa3
up
rdjanuar Oct 18, 2024
728fcac
fix: package json & pnpm
rdjanuar Oct 18, 2024
fa3ce65
fix: EOL package json
rdjanuar Oct 18, 2024
0683ec4
fix: EOL v2 package json
rdjanuar Oct 18, 2024
b900dad
up
benjamincanac Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/runtime/components/data/Table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,12 +290,16 @@ export default defineComponent({

function compare (a: any, z: any) {
if (typeof props.by === 'string') {
const property = props.by as unknown as any
return a?.[property] === z?.[property]
const accesorFn = accessor(props.by)
return accesorFn(a) === accesorFn(z)
}
return props.by(a, z)
}

function accessor <T extends Record<string, any>> (key: string) {
return (obj: T) => get(obj, key)
}

function isSelected (row: TableRow) {
if (!props.modelValue) {
return false
Expand Down