Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CommandPalette/SelectMenu): missing translations #3057

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix(CommandPalette/SelectMenu): missing translations #3057

merged 3 commits into from
Jan 10, 2025

Conversation

Malik-Jouda
Copy link
Contributor

@Malik-Jouda Malik-Jouda commented Jan 9, 2025 •
edited
Loading

🔗 Linked issue

Resolves #2906

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

selectMenu: Search...
commandPalette: Type a command or search...

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 9, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@3057

commit: f8406fa

@benjamincanac
Copy link
Member

benjamincanac commented Jan 9, 2025 •
edited
Loading

Would you guys mind reviewing this? 🙏

@rigtigeEmil
Copy link
Contributor

da is good 👍

d3xt3r9
d3xt3r9 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@d3xt3r9 d3xt3r9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

el.ts is OK

narr07
narr07 approved these changes Jan 9, 2025
View reviewed changes
src/runtime/locale/id.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍🏻

@Arcitezz
Copy link
Contributor

Arcitezz commented Jan 9, 2025

nl.ts is good

nttps
nttps approved these changes Jan 9, 2025
View reviewed changes
src/runtime/locale/th.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. 👍

@hywax
Copy link
Collaborator

hywax commented Jan 9, 2025

ru is ok

@BlackWhite2000
Copy link
Contributor

zh_hans zh_hant is ok

@kicaj
Copy link
Contributor

kicaj commented Jan 9, 2025

pl looks good! 👌

@sandros94
Copy link
Collaborator

it looks good

jakubkoje
jakubkoje reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jakubkoje jakubkoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sk and cs are OK

@eduayme
Copy link
Contributor

eduayme commented Jan 9, 2025

es is good

ilya-buligin
ilya-buligin approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ilya-buligin ilya-buligin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uk is good

@HigherOrderLogic
Copy link
Contributor

vi is good.

Bitcreep
Bitcreep reviewed Jan 10, 2025
View reviewed changes
src/runtime/locale/et.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@MuhammadM1998
Copy link
Contributor

ar is good

@benjamincanac benjamincanac changed the title fix(locales): missing translations fix(CommandPalette/SelectMenu): missing translations Jan 10, 2025
@benjamincanac benjamincanac merged commit d5dba0e into nuxt:v3 Jan 10, 2025
2 checks passed
@benjamincanac
Copy link
Member

Thank you all! 😊

@benjamincanac benjamincanac added the v3 #1289 label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bitcreep Bitcreep Bitcreep left review comments

@jakubkoje jakubkoje jakubkoje left review comments

@samuelbelo samuelbelo samuelbelo left review comments

@d3xt3r9 d3xt3r9 d3xt3r9 approved these changes

@nttps nttps nttps approved these changes

@narr07 narr07 narr07 approved these changes

@ilya-buligin ilya-buligin ilya-buligin approved these changes

@ChristopheCVB ChristopheCVB Awaiting requested review from ChristopheCVB

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v3: Missing translations