[readme]: removing cdnvm command in readme for bashrc file #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an uncessary `cdnvm "$PWD" || exit` taking place and not all the systems that have bash come with it, so its uncessary
hasham7861
changed the title
ljharb
requested changes
Nov 18, 2023
| @@ -626,7 +626,7 @@ cdnvm() { | |||
| } | |||
|
|
|||
| alias cd='cdnvm' | |||
| cdnvm "$PWD" || exit | |||
There was a problem hiding this comment.
$PWD is in posix, afaik; which systems don't come with it?
if the command isn't here, then a new shell won't have the logic applied, so it does have to remain.
There was a problem hiding this comment.
for some reason it doesn't come by default on pop os, and kubuntu
There was a problem hiding this comment.
Perhaps those shells aren’t POSIX-compliant, then?
ljharb
force-pushed
the
master
branch
2 times, most recently
from
c6cfc3a
to
c20db2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an uncessary
cdnvm "$PWD" || exittaking place and not all the systems that have bash come with $PWD variable and it was uncessarly causing my terminal to shut down, so I thought I remove it as it is uncessary