[Fix] install.sh: install looks for .zshenv

[mrdomino]

A zsh user may have set ZDOTDIR to something other than $HOME, in which case the profile and rc files will not be located under $HOME. But unless the system zshenv has done something unusual, it is usually a safe bet that there will be a $HOME/.zshenv that, if nothing else, will be setting up ZDOTDIR.

[ljharb]

Thanks, I didn't know any of this about zsh.

Is there a way we can add some tests to cover this functionality?

[mrdomino]

Unfortunately, I have a lot on my plate right now. (It took until now to get to this email in my inbox, for example...)

A full integration test would probably just run the install script and then check that ~/.zshenv was modified if it was present.

Alternatively, if you wanted to get fancy, you could say something like:

#!/bin/sh
touch ~/.zshenv
ZDOTDIR=$(mktemp -d)
trap 'rmdir "$ZDOTDIR"' EXIT
zsh -c 'whence nvm >/dev/null 2>&1'
exitcode=$?
if [ $exitcode -eq 0 ]; then
  echo success
else
  echo failure
fi

And for the check for whether you need to modify the environment, you could just run $SHELL -c 'type nvm >/dev/null 2>&1' and similarly check the exit code (of the shell) - that should work for bash/zsh/ksh, I don't know about fish or tcsh...

But as far as I'm concerned all of that is "extra credit".

In any event this drive-by PR is presented "as is"; if it can be used, great, if not, shucks.