Skip to content

Commit

Permalink
leak-fix: must call splice of widget children not children
Browse files Browse the repository at this point in the history
  • Loading branch information
nyannyacha committed Jan 13, 2021
1 parent 8c6ad10 commit a937faf
Show file tree
Hide file tree
Showing 17 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion bundles/puxi.js/dist/puxi.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bundles/puxi.js/lib/puxi.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*!
* puxi.js - v1.0.1
* Compiled Thu, 10 Dec 2020 13:33:26 UTC
* Compiled Wed, 13 Jan 2021 06:08:52 UTC
*
* puxi.js is licensed under the MIT License.
* http://www.opensource.org/licenses/mit-license
Expand Down
2 changes: 1 addition & 1 deletion bundles/puxi.js/lib/puxi.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*!
* puxi.js - v1.0.1
* Compiled Thu, 10 Dec 2020 13:33:26 UTC
* Compiled Wed, 13 Jan 2021 06:08:52 UTC
*
* puxi.js is licensed under the MIT License.
* http://www.opensource.org/licenses/mit-license
Expand Down
4 changes: 2 additions & 2 deletions packages/core/dist/puxi-core.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/core/dist/puxi-core.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/core/lib/puxi-core.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/core/lib/puxi-core.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/core/src/Stage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class Stage extends PIXI.Container

if (index !== -1)
{
this.children.splice(index, 1);
this.widgetChildren.splice(index, 1);
UIObject.parent = null;
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/dist/puxi-kit.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/kit/lib/puxi-kit.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/kit/lib/puxi-kit.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*!
* @puxi/kit - v1.0.1
* Compiled Thu, 10 Dec 2020 13:33:26 UTC
* Compiled Wed, 13 Jan 2021 06:08:52 UTC
*
* @puxi/kit is licensed under the MIT License.
* http://www.opensource.org/licenses/mit-license
Expand Down
2 changes: 1 addition & 1 deletion packages/navigation/dist/puxi-navigation.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/navigation/lib/puxi-navigation.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/navigation/lib/puxi-navigation.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*!
* @puxi/navigation - v1.0.1
* Compiled Thu, 10 Dec 2020 13:33:26 UTC
* Compiled Wed, 13 Jan 2021 06:08:52 UTC
*
* @puxi/navigation is licensed under the MIT License.
* http://www.opensource.org/licenses/mit-license
Expand Down
2 changes: 1 addition & 1 deletion packages/tween/dist/puxi-tween.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/tween/lib/puxi-tween.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/tween/lib/puxi-tween.mjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*!
* @puxi/tween - v1.0.1
* Compiled Thu, 10 Dec 2020 13:33:26 UTC
* Compiled Wed, 13 Jan 2021 06:08:52 UTC
*
* @puxi/tween is licensed under the MIT License.
* http://www.opensource.org/licenses/mit-license
Expand Down

0 comments on commit a937faf

Please sign in to comment.