Mark message send to avoid duplicate send on final status update #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
force-pushed
the
fix-sending-multiple-logs
branch
from
258c283
to
c0b2b8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=======================================
Coverage 74.52% 74.52%
=======================================
Files 111 111
Lines 13450 13462 +12
=======================================
+ Hits 10023 10032 +9
- Misses 2697 2698 +1
- Partials 730 732 +2 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
fix-sending-multiple-logs
branch
from
42b243d
to
1a29d1b
Compare
rowanseymour
reviewed
Nov 1, 2024
backends/rapidpro/backend_test.go
Outdated
| ts.True(sent) | ||
|
|
||
| m = readMsgFromDB(ts.b, msg.ID()) | ||
| ts.Equal(m.Status_, courier.MsgStatusWired) |
There was a problem hiding this comment.
this seems wrong but I'm still not getting how a message in this state could be picked up 5 minutes later for retrying
There was a problem hiding this comment.
you mean Failed should not be changed back to Wired?
norkans7
commented
Nov 1, 2024
| ts.NoError(err) | ||
|
|
||
| m := readMsgFromDB(ts.b, msg.ID()) | ||
| ts.Equal(m.Status_, courier.MsgStatusFailed) |
There was a problem hiding this comment.
@rowanseymour any idea why this line fails for package tests but pass for the individual test?
There was a problem hiding this comment.
norkans7
force-pushed
the
fix-sending-multiple-logs
branch
from
1a29d1b
to
ad459db
Compare
Prevent failed msgs to change status back to some other status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.