Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new task to handle bulk session timeouts #363

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Nov 15, 2024

Addresses half of #356.

If an org has < 10 timeouts then they are queued directly to the handler queue as we've always done.

If an org has >= 10 timeouts then they are queued as bulk timeout tasks (batches of 100) in the throttle queue (the one throttled by outbox size).

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 62.14%. Comparing base (0c6fd11) to head (ec06eeb).

Files with missing lines Patch % Lines
core/tasks/timeouts/cron.go 70.58% 6 Missing and 4 partials ⚠️
core/tasks/timeouts/bulk_timeout.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   62.00%   62.14%   +0.14%     
==========================================
  Files         193      194       +1     
  Lines       13751    13782      +31     
==========================================
+ Hits         8526     8565      +39     
+ Misses       4315     4306       -9     
- Partials      910      911       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants