Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PHONE_NUMBER_CARRIER.getSafeDisplayName of the JAVA version #149

Conversation

hemachandran-kalaimani
Copy link
Contributor

Refer to issue #146

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85be252) 49.66% compared to head (325662c) 49.98%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   49.66%   49.98%   +0.31%     
==========================================
  Files           9        9              
  Lines        3304     3309       +5     
==========================================
+ Hits         1641     1654      +13     
+ Misses       1521     1512       -9     
- Partials      142      143       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour
Copy link
Member

rowanseymour commented Nov 17, 2023

Thanks!

@rowanseymour rowanseymour merged commit bc8db54 into nyaruka:main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants