Fix the response type for listing of scheduled messages

nylas · Oct 30, 2024 · 5976004 · 5976004
1 parent 988c45d
commit 5976004
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ### Unreleased
 * Added support for `Accept-Encoding: gzip` in HTTP headers
+* Fixed response type for returning list of scheduled messages
 
 ### [2.5.0] - Released 2024-09-25
 

diff --git a/src/main/kotlin/com/nylas/resources/Messages.kt b/src/main/kotlin/com/nylas/resources/Messages.kt
@@ -111,9 +111,9 @@ class Messages(client: NylasClient) : Resource<Message>(client, Message::class.j
    */
   @Throws(NylasApiError::class, NylasSdkTimeoutError::class)
   @JvmOverloads
-  fun listScheduledMessages(identifier: String, overrides: RequestOverrides? = null): Response<ScheduledMessagesList> {
+  fun listScheduledMessages(identifier: String, overrides: RequestOverrides? = null): ListResponse<ScheduledMessage> {
     val path = String.format("v3/grants/%s/messages/schedules", identifier)
-    val responseType = Types.newParameterizedType(Response::class.java, ScheduledMessagesList::class.java)
+    val responseType = Types.newParameterizedType(ListResponse::class.java, ScheduledMessage::class.java)
     return client.executeGet(path, responseType, overrides = overrides)
   }
 

diff --git a/src/test/kotlin/com/nylas/resources/MessagesTests.kt b/src/test/kotlin/com/nylas/resources/MessagesTests.kt
@@ -300,15 +300,15 @@ class MessagesTests {
       val typeCaptor = argumentCaptor<Type>()
       val queryParamCaptor = argumentCaptor<IQueryParams>()
       val overrideParamCaptor = argumentCaptor<RequestOverrides>()
-      verify(mockNylasClient).executeGet<Response<Message>>(
+      verify(mockNylasClient).executeGet<ListResponse<ScheduledMessage>>(
         pathCaptor.capture(),
         typeCaptor.capture(),
         queryParamCaptor.capture(),
         overrideParamCaptor.capture(),
       )
 
       assertEquals("v3/grants/$grantId/messages/schedules", pathCaptor.firstValue)
-      assertEquals(Types.newParameterizedType(Response::class.java, ScheduledMessagesList::class.java), typeCaptor.firstValue)
+      assertEquals(Types.newParameterizedType(ListResponse::class.java, ScheduledMessage::class.java), typeCaptor.firstValue)
       assertNull(queryParamCaptor.firstValue)
     }