Code review

[NathanW2]

Don't merge this. This is just the comments from my mini code review while on the plane yesterday

Have a read though and see what you think.

[nzfarmer1]

Thanks Nathan

Much appreciated.

You got to the heart of the plugin quickly and have found some Achilles heals in my coding. Much appreciated.

In my next refactor I want to expose a TelemetryLayer API such that 3rd party plugins can provide their own topic managers; feature dialogs; and connect to the tlayer.featureUpdated(tlayer,feature) signal.

Initially I thought people would share the GIT code base but am coming to the view that exposing an API is a lot more elegant.

It also means I can rip out the AgSense stuff into a private QGIS repo and just keep the core MQTT handlers.

However, this will mean some factory/instance methods are required - I am not 100% sure of your preferred approach here. Also, welcome your thoughts on one plugin using another. Need to factor in contingencies for changing Plugin availability and loading order. I did a quick test and the name space TelemetryLayer would be available publicly.