Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in sender/receiver index calculation #135

Closed
wants to merge 5 commits into from
Closed

Conversation

validev
Copy link
Contributor

@validev validev commented Dec 12, 2019

No description provided.

@mefistotelis
Copy link
Collaborator

I would be very surprised if the core structure of DUML had changed, or was incorrectly reverse engineered.

https://github.com/o-gs/dji-firmware-tools/blob/master/comm_dissector/wireshark/dji-dumlv1-proto.lua#L3101

Please make sure you're not misinterpreting something.
This change would have very large implications.

@validev
Copy link
Contributor Author

validev commented Dec 13, 2019

fact is i cannot formulate a packet to receiver "1f". "-r 1501" translates to "2f" without my patch. I had same oddities with the sender parameter: 1001 translates to "2a". which is ok, because I need "2a", but what if i needed "1a"? Maybe I'm grossly misinterpreting sth here and the "1f" is accomplished by some other parameters I havent considered. If so, I stand corrected. Please, how would you correctly send a duml to "1f"?

@mefistotelis
Copy link
Collaborator

m1501 means --receiver_type 15 and --receiver_index 1. In this patch, you just removed one bit from "receiver_type". Definitely not what you wanted.

@validev
Copy link
Contributor Author

validev commented Dec 13, 2019

Ok, I see my error now. the data field is 5 bits, not 4. I'm sorry.

@validev validev closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants