-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial 3 to CI #567
base: main
Are you sure you want to change the base?
Add tutorial 3 to CI #567
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! I had a couple of naive questions about the tutorial runner for my understanding. Also don't understand what role mina-lightnet plays here
The expected output is: | ||
|
||
```sh | ||
✔ Create an accompanying UI project too? · none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity - does the tutorial runner parse this to figure out what option to select? or how does it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it only parses shell commands if they begin with $
, rest is ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how does it select the none
option then? there's a second snippet which shows the choice but it also doesn't have a leading $
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or this particular snippet doesn't execute or do anything, it's just rendered to indicate to the reader what to choose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't get how the tutorial runner ends up making a choice for the UI project option 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh!! We have a flag --ui none
that the runner is using :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs style guide describes the tutorial runner, can we verify the technical accuracy, please?
```sh | ||
$ rm src/Add.ts | ||
$ rm src/Add.test.ts | ||
$ rm src/interact.ts | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could be collapsed into one line
$ rm src/Add.ts src/Add.test.ts src/interact.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for teaching me why we add the ts code in comments, the tutorial runner needs it.
LGTM
this adds tutorial 3 to the CI tutorial runner. It deploys the contract from tutorial 01 to a local network using the zkapp cli.
FYI some changes to the tutorials (01 and 03) are due to automatic formatting, they just deleted some trailing spaces :X