Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm custom gates - revived edition #38

Closed
wants to merge 5 commits into from
Closed

Wasm custom gates - revived edition #38

wants to merge 5 commits into from

Conversation

rbonichon
Copy link
Contributor

@rbonichon rbonichon commented Jun 7, 2023 •
edited
Loading

Revival of #8. Supersedes #18

@rbonichon rbonichon requested a review from a team as a code owner June 7, 2023 20:28
This was referenced Jun 7, 2023
Closed
Closed
@mitschabaude
Copy link
Contributor

mitschabaude commented Jun 8, 2023 •
edited
Loading

heads up: I did merge #18 into this branch, after all, so that these changes are not in conflict with the reverting of the same changes that we merged into main. the unreverting merge 8a1fd7f was clean, no extra changes, just more resilient git history :D

@rbonichon rbonichon force-pushed the rb/wasm-custom-gates-revived branch from 3872e20 to 9e53cdc Compare August 3, 2023 13:21
@rbonichon rbonichon mentioned this pull request Aug 16, 2023
Merged
5 tasks
@dannywillems
Copy link
Member

Note from a call with @rbonichon: bindings.js does not include changes for the lookup verifier index.

@rbonichon rbonichon force-pushed the rb/wasm-custom-gates-revived branch 2 times, most recently from 0b6a9e8 to 40454b9 Compare August 18, 2023 11:51
@rbonichon
Copy link
Contributor Author

Note from a call with @rbonichon: bindings.js does not include changes for the lookup verifier index.

Now it does. This PR has been re-built on #114

@rbonichon rbonichon force-pushed the rb/wasm-custom-gates-revived branch 4 times, most recently from 0bc0852 to 4bb89e2 Compare August 22, 2023 11:54
@rbonichon rbonichon closed this Sep 12, 2023
@mitschabaude mitschabaude deleted the rb/wasm-custom-gates-revived branch May 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

@dannywillems dannywillems dannywillems left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbonichon @mitschabaude @dannywillems