Merge pull request #1414 from robrobbins/mina-signer-fixes

Cleanups for mina-signer

README-dev.md

@@ -141,8 +141,22 @@ npm run test
 npm run test:unit
 ```
 
+In order for the mina-signer tests to run you must also build from inside its subdirectory:
+
+```sh
+cd src/mina-signer
+npm run build
+cd ../..
+```
+
 This runs all the unit tests and provides you with a summary of the test results.
 
+Note that you can run individual jest tests via the command:
+
+```sh
+./jest <path/to/test.ts>
+```
+
 You can also run integration tests by running:
 
 ```sh

src/mina-signer/src/rosetta.ts

@@ -27,12 +27,13 @@ function fieldToHex<T extends Field | Scalar>(
 ) {
   let bytes = binable.toBytes(x);
   // set highest bit (which is empty)
-  bytes[bytes.length - 1] &= Number(paddingBit) << 7;
-  // map each byte to a hex string of length 2
+  bytes[bytes.length - 1] |= Number(paddingBit) << 7;
+  // map each byte to a 0-padded hex string of length 2
   return bytes
-    .map((byte) => byte.toString(16).split('').reverse().join(''))
+    .map((byte) => byte.toString(16).padStart(2, '0').split('').reverse().join(''))
     .join('');
 }
+
 function fieldFromHex<T extends Field | Scalar>(
   binable: Binable<T>,
   hex: string