Twisted Edwards curves operations #1949
Open
+1,086
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querolita
force-pushed
the
feature/eddsa/twisted
branch
from
b741643 to
576725d
Compare
querolita
commented
Jan 16, 2025
| toBigint({ x, y }: Point) { | ||
| let x_ = Field3.toBigint(x); | ||
| let y_ = Field3.toBigint(y); | ||
| return { x: x_, y: y_, infinity: x_ === 0n && y_ === 1n }; |
There was a problem hiding this comment.
I created an equivalent Point type (elliptic-curve also has it) with the difference that the infinity is not always set to false as it is the case in the other gadgets.
| let witnesses = exists(12, () => { | ||
| let [x1_, x2_, y1_, y2_] = Field3.toBigints(x1, x2, y1, y2); | ||
|
|
||
| // TODO: reuse code in twistedAdd to avoid recomputing these |
There was a problem hiding this comment.
This would be a nice feature and much cleaner code, but apparently this wouldn't be a trivial refactor at all. Ideas for the future: inspiration from the interpreter structure in o1vm?
dannywillems
reviewed
Feb 6, 2025
| * @param hex - The hexadecimal string representing the uncompressed elliptic curve point. | ||
| * @returns - A point on the foreign curve, parsed from the given hexadecimal string. | ||
| * | ||
| * @throws - Throws an error if the input is not a valid public key. |
There was a problem hiding this comment.
Aren't we more explicit in o1js for the kind of exceptions we raise? Like the user should be able to do a pattern matching on the exception to understand more the kind of issues that happened.
Trivo25
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the twisted counterpart of the operations found in
/src/lib/provable/gadgets/elliptic-curve.ts. It is a necessary step to support EdDSA, which uses the twisted curve Ed25519. Related to o1-labs/o1js-bindings#317.