New v2 bindings layer #2032
Open
New v2 bindings layer #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
requested review from
45930 and
Geometer1729
and removed request for
a team
Geometer1729
approved these changes
Feb 18, 2025
45930
reviewed
Feb 18, 2025
src/build/js-layout-to-types-v2.mjs
Outdated
There was a problem hiding this comment.
Are these build files meant to be included here?
There was a problem hiding this comment.
this file is just the script to build the bindings, if thats what you mean
src/lib/provable/bool.ts
Outdated
| /** | ||
| * Boolean AND operation across a list of booleans, returns `Bool(true)` if all elements in the list are true. | ||
| */ | ||
| static allTrue(list: (Bool | boolean)[]): Bool { |
There was a problem hiding this comment.
Is this included from a different PR? If not, should it be separated?
There was a problem hiding this comment.
cherry picked from #2038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same vibe as #2036 but introduces the new bindings layer and seperates the two layers via distinct v1/v2 folders
bindings o1-labs/o1js-bindings#336