improve documentation of analyzeMethods #2037
Open
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can wait for #2033 to land to make this PR easier to review |
…is-merge-main Merge main into 2025 02 document circuit analysis
…peof analyzeMethod>>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some typing for constraint system summaries and method analysis results which were previously implied. I think the new type annotations make it easier to follow to the source what "analyze methods" actually means, as it gives breadcrumbs back to
function constraintSystemToJS(cs: MlConstraintSystem): ConstraintSystemSummary {.