Export Internal Testing Tools #2065
Conversation
There was a problem hiding this comment.
So a problem seems to be that the testing framework relies on Nodejs imports, and this isn't compatible with the web version.
On the other hand, o1js is designed to work in all JS runtimes.
I think for this reason it would be cleaner to export the testing framework as a separate package or package entry-point, like we already do with mina-signer.
This is a general direction we always wanted to move in: Have separate entry-points like o1js/light, o1js/prover and o1js/testing with different levels of functionality
| external: ['*.bc.js'], | ||
| external: ['*.bc.js', 'node:assert/strict'], |
There was a problem hiding this comment.
this breaks the web version doesn't it?
There was a problem hiding this comment.
yes, I wasn't sure how acceptable is this since testing tools won't be used in web but it still breaks the web version.
| let { constraintSystemSync } = await synchronousRunners(); | ||
| let constraintSystemSync: any; | ||
| (async () => { | ||
| constraintSystemSync = await synchronousRunners(); | ||
| })(); |
There was a problem hiding this comment.
how is this supposed to work? to me it seems to impose an ugly implicit assumption that bindings are initiated before using the testing framework. this should be made explicit
There was a problem hiding this comment.
this doesn't work. I was testing this to prevent having a top-level await.
|
|
||
| export { Testing }; | ||
|
|
||
| namespace Testing { |
There was a problem hiding this comment.
I don't like how you pack unqualified names like or and bool, that have nothing to do with each other, into a flat namespace. why not export three namespaces?
There was a problem hiding this comment.
I don't like either. I am just experimenting for now.
This PR exposes existing internal testing tools for use of third party primitive developers.
Changes:
Testingnamespace insrc/lib/testing/testing.tsthat organizes the testing tools.Testingnamespace is exported fromExperimental.src/examples/testing.tsto demonstrate the use ofTestingutilities.