Poly-commitment: rename evaluation_proof into ipa

Result of:
```
find arrabiata -name "*.rs" -type f -exec sed -i 's/evaluation_proof/ipa/g' {} \;
```
(replace arrabiata with folding, ivc, kimchi, msg, o1vm, poly_commitment, tools)

followed by cargo +nightly fmt and `git mv poly-commitment/src/evaluation_proof.rs poly-commitment/src/ipa.rs`.

arrabiata/src/witness.rs

@@ -6,7 +6,7 @@ use log::{debug, info};
 use num_bigint::{BigInt, BigUint};
 use num_integer::Integer;
 use o1_utils::field_helpers::FieldHelpers;
-use poly_commitment::{commitment::CommitmentCurve, evaluation_proof::SRS, PolyComm, SRS as _};
+use poly_commitment::{commitment::CommitmentCurve, ipa::SRS, PolyComm, SRS as _};
 use rayon::iter::{IntoParallelRefIterator, ParallelIterator};
 use std::time::Instant;
 

folding/src/standard_config.rs

@@ -430,7 +430,7 @@ mod example {
 
         let constraints = vec![constraint()];
         let domain = Radix2EvaluationDomain::<Fp>::new(2).unwrap();
-        let mut srs = poly_commitment::evaluation_proof::SRS::<Curve>::create(2);
+        let mut srs = poly_commitment::ipa::SRS::<Curve>::create(2);
         srs.add_lagrange_basis(domain);
         // this is the default structure, which does nothing or panics if
         // indexed (as it shouldn't be indexed)

folding/tests/test_decomposable_folding.rs

@@ -9,7 +9,7 @@ use folding::{
 };
 use itertools::Itertools;
 use kimchi::circuits::{expr::Variable, gate::CurrOrNext};
-use poly_commitment::{evaluation_proof::SRS, SRS as _};
+use poly_commitment::{ipa::SRS, SRS as _};
 use rand::thread_rng;
 use std::{collections::BTreeMap, ops::Index};
 

folding/tests/test_folding_with_quadriticization.rs

@@ -12,7 +12,7 @@ use folding::{
 use itertools::Itertools;
 use kimchi::circuits::{expr::Variable, gate::CurrOrNext};
 use mina_poseidon::{constants::PlonkSpongeConstantsKimchi, sponge::DefaultFqSponge};
-use poly_commitment::{evaluation_proof::SRS, SRS as _};
+use poly_commitment::{ipa::SRS, SRS as _};
 use rand::thread_rng;
 use std::{collections::BTreeMap, ops::Index};
 

folding/tests/test_quadraticization.rs

@@ -8,7 +8,7 @@ use folding::{
     Witness,
 };
 use kimchi::circuits::{expr::Variable, gate::CurrOrNext};
-use poly_commitment::{evaluation_proof::SRS, SRS as _};
+use poly_commitment::{ipa::SRS, SRS as _};
 use std::{
     collections::hash_map::DefaultHasher,
     hash::{Hash, Hasher},
@@ -146,7 +146,7 @@ fn test_with_constraints(constraints: Vec<FoldingCompatibleExpr<TestConfig>>) ->
     use ark_poly::EvaluationDomain;
 
     let domain = Radix2EvaluationDomain::<Fp>::new(2).unwrap();
-    let mut srs = poly_commitment::evaluation_proof::SRS::<Curve>::create(2);
+    let mut srs = poly_commitment::ipa::SRS::<Curve>::create(2);
     srs.add_lagrange_basis(domain);
 
     let (scheme, _) = FoldingScheme::<TestConfig>::new(constraints, &srs, domain, &());

folding/tests/test_vanilla_folding.rs

@@ -23,7 +23,7 @@ use kimchi::{
     curve::KimchiCurve,
 };
 use mina_poseidon::{constants::PlonkSpongeConstantsKimchi, sponge::DefaultFqSponge, FqSponge};
-use poly_commitment::{evaluation_proof::SRS, SRS as _};
+use poly_commitment::{ipa::SRS, SRS as _};
 use rand::thread_rng;
 use std::println as debug;
 
@@ -396,7 +396,7 @@ mod checker {
 fn test_folding_instance() {
     let constraints = constraints();
     let domain = Radix2EvaluationDomain::<Fp>::new(2).unwrap();
-    let mut srs = poly_commitment::evaluation_proof::SRS::<Curve>::create(2);
+    let mut srs = poly_commitment::ipa::SRS::<Curve>::create(2);
     srs.add_lagrange_basis(domain);
 
     let mut fq_sponge = BaseSponge::new(Curve::other_curve_sponge_params());

ivc/src/prover.rs

@@ -31,7 +31,7 @@ use mina_poseidon::{sponge::ScalarChallenge, FqSponge};
 use o1_utils::ExtendedDensePolynomial;
 use poly_commitment::{
     commitment::{absorb_commitment, CommitmentCurve, PolyComm},
-    evaluation_proof::DensePolynomialOrEvaluations,
+    ipa::DensePolynomialOrEvaluations,
     kzg::{KZGProof, PairingSRS},
     OpenProof, SRS,
 };

kimchi/src/bench.rs

@@ -7,7 +7,7 @@ use mina_poseidon::{
     sponge::{DefaultFqSponge, DefaultFrSponge},
 };
 use o1_utils::math;
-use poly_commitment::{commitment::CommitmentCurve, evaluation_proof::OpeningProof, SRS as _};
+use poly_commitment::{commitment::CommitmentCurve, ipa::OpeningProof, SRS as _};
 
 use crate::{
     circuits::{

kimchi/src/circuits/expr.rs

@@ -3539,7 +3539,7 @@ pub mod test {
     use ark_ff::UniformRand;
     use mina_curves::pasta::{Fp, Pallas, Vesta};
     use poly_commitment::{
-        evaluation_proof::{endos, OpeningProof, SRS},
+        ipa::{endos, OpeningProof, SRS},
         SRS as _,
     };
     use rand::{prelude::StdRng, SeedableRng};

kimchi/src/curve.rs

@@ -10,7 +10,7 @@ use mina_poseidon::poseidon::ArithmeticSpongeParams;
 use once_cell::sync::Lazy;
 use poly_commitment::{
     commitment::{CommitmentCurve, EndoCurve},
-    evaluation_proof::endos,
+    ipa::endos,
 };
 
 /// Represents additional information that a curve needs in order to be used

kimchi/src/oracles.rs

@@ -38,7 +38,7 @@ where
 #[cfg(feature = "ocaml_types")]
 pub mod caml {
     use ark_ff::PrimeField;
-    use poly_commitment::{commitment::shift_scalar, evaluation_proof::OpeningProof};
+    use poly_commitment::{commitment::shift_scalar, ipa::OpeningProof};
 
     use crate::{
         circuits::scalars::caml::CamlRandomOracles, curve::KimchiCurve, error::VerifyError,

kimchi/src/precomputed_srs.rs

@@ -11,7 +11,7 @@
 
 use crate::curve::KimchiCurve;
 use ark_serialize::{CanonicalDeserialize, CanonicalSerialize};
-use poly_commitment::{evaluation_proof::SRS, PolyComm};
+use poly_commitment::{ipa::SRS, PolyComm};
 use serde::{Deserialize, Serialize};
 use serde_with::serde_as;
 use std::{collections::HashMap, fs::File, io::BufReader, path::PathBuf};

kimchi/src/prover.rs

@@ -46,7 +46,7 @@ use poly_commitment::{
     commitment::{
         absorb_commitment, b_poly_coefficients, BlindedCommitment, CommitmentCurve, PolyComm,
     },
-    evaluation_proof::DensePolynomialOrEvaluations,
+    ipa::DensePolynomialOrEvaluations,
     OpenProof, SRS as _,
 };
 use rayon::prelude::*;
@@ -1450,7 +1450,7 @@ where
         }
 
         //~ 1. Create an aggregated evaluation proof for all of these polynomials at $\zeta$ and $\zeta\omega$ using $u$ and $v$.
-        internal_tracing::checkpoint!(internal_traces; create_aggregated_evaluation_proof);
+        internal_tracing::checkpoint!(internal_traces; create_aggregated_ipa);
         let proof = OpenProof::open(
             &*index.srs,
             group_map,
@@ -1507,7 +1507,7 @@ internal_tracing::decl_traces!(internal_traces;
     compute_ft_poly,
     ft_eval_zeta_omega,
     build_polynomials,
-    create_aggregated_evaluation_proof,
+    create_aggregated_ipa,
     create_recursive_done);
 
 #[cfg(feature = "ocaml_types")]
@@ -1517,7 +1517,7 @@ pub mod caml {
     use ark_ec::AffineRepr;
     use poly_commitment::{
         commitment::caml::CamlPolyComm,
-        evaluation_proof::{caml::CamlOpeningProof, OpeningProof},
+        ipa::{caml::CamlOpeningProof, OpeningProof},
     };
 
     #[cfg(feature = "internal_tracing")]

kimchi/src/prover_index.rs

@@ -145,7 +145,7 @@ pub mod testing {
     use ark_ff::PrimeField;
     use ark_poly::{EvaluationDomain, Radix2EvaluationDomain as D};
     use poly_commitment::{
-        evaluation_proof::{OpeningProof, SRS},
+        ipa::{OpeningProof, SRS},
         OpenProof,
     };
 

kimchi/src/snarky/folding.rs

@@ -8,7 +8,7 @@ use crate::{
 use ark_ec::AffineRepr;
 use ark_ff::{BigInteger, One, PrimeField};
 use mina_curves::pasta::Fp;
-use poly_commitment::{evaluation_proof::OpeningProof, OpenProof};
+use poly_commitment::{ipa::OpeningProof, OpenProof};
 use std::{marker::PhantomData, ops::Add};
 
 mod instance;

kimchi/src/snarky/range_checks.rs

@@ -165,7 +165,7 @@ mod test {
         constants::PlonkSpongeConstantsKimchi,
         sponge::{DefaultFqSponge, DefaultFrSponge},
     };
-    use poly_commitment::evaluation_proof::OpeningProof;
+    use poly_commitment::ipa::OpeningProof;
 
     type BaseSponge = DefaultFqSponge<VestaParameters, PlonkSpongeConstantsKimchi>;
     type ScalarSponge = DefaultFrSponge<Fp, PlonkSpongeConstantsKimchi>;

kimchi/src/snarky/tests.rs

@@ -14,7 +14,7 @@ use mina_poseidon::{
     constants::PlonkSpongeConstantsKimchi,
     sponge::{DefaultFqSponge, DefaultFrSponge},
 };
-use poly_commitment::evaluation_proof::OpeningProof;
+use poly_commitment::ipa::OpeningProof;
 
 use super::prelude::*;
 

kimchi/src/tests/endomul.rs

@@ -13,7 +13,7 @@ use mina_poseidon::{
     constants::PlonkSpongeConstantsKimchi,
     sponge::{DefaultFqSponge, DefaultFrSponge, ScalarChallenge},
 };
-use poly_commitment::evaluation_proof::endos;
+use poly_commitment::ipa::endos;
 use rand::{rngs::StdRng, SeedableRng};
 use std::{array, ops::Mul};
 

kimchi/src/tests/endomul_scalar.rs

@@ -12,7 +12,7 @@ use mina_poseidon::{
     constants::PlonkSpongeConstantsKimchi,
     sponge::{DefaultFqSponge, DefaultFrSponge, ScalarChallenge},
 };
-use poly_commitment::evaluation_proof::endos;
+use poly_commitment::ipa::endos;
 use rand::{rngs::StdRng, SeedableRng};
 use std::array;
 

kimchi/src/tests/foreign_field_add.rs

@@ -29,7 +29,7 @@ use num_bigint::{BigUint, RandBigInt};
 use num_traits::FromPrimitive;
 use o1_utils::{foreign_field::ForeignElement, tests::make_test_rng, FieldHelpers, Two};
 use poly_commitment::{
-    evaluation_proof::{endos, OpeningProof, SRS},
+    ipa::{endos, OpeningProof, SRS},
     SRS as _,
 };
 use rand::{rngs::StdRng, Rng};

kimchi/src/tests/framework.rs

@@ -27,7 +27,7 @@ use groupmap::GroupMap;
 use mina_poseidon::sponge::FqSponge;
 use num_bigint::BigUint;
 use poly_commitment::{
-    commitment::CommitmentCurve, evaluation_proof::OpeningProof as DlogOpeningProof, OpenProof,
+    commitment::CommitmentCurve, ipa::OpeningProof as DlogOpeningProof, OpenProof,
 };
 use std::{fmt::Write, time::Instant};
 

kimchi/src/tests/not.rs

@@ -23,7 +23,7 @@ use mina_poseidon::{
 };
 use num_bigint::BigUint;
 use o1_utils::{BigUintHelpers, BitwiseOps, FieldHelpers, RandomField};
-use poly_commitment::evaluation_proof::OpeningProof;
+use poly_commitment::ipa::OpeningProof;
 
 type PallasField = <Pallas as AffineRepr>::BaseField;
 type VestaField = <Vesta as AffineRepr>::BaseField;

kimchi/src/tests/range_check.rs

@@ -34,7 +34,7 @@ use mina_poseidon::{
 };
 use poly_commitment::{
     commitment::CommitmentCurve,
-    evaluation_proof::{endos, OpeningProof, SRS},
+    ipa::{endos, OpeningProof, SRS},
     SRS as _,
 };
 

kimchi/src/tests/rot.rs

@@ -28,7 +28,7 @@ use mina_poseidon::{
 };
 use o1_utils::Two;
 use poly_commitment::{
-    evaluation_proof::{endos, OpeningProof, SRS},
+    ipa::{endos, OpeningProof, SRS},
     SRS as _,
 };
 use rand::Rng;

kimchi/src/tests/serde.rs

@@ -19,7 +19,7 @@ use mina_poseidon::{
 };
 use poly_commitment::{
     commitment::CommitmentCurve,
-    evaluation_proof::{OpeningProof, SRS},
+    ipa::{OpeningProof, SRS},
     SRS as _,
 };
 use std::{array, time::Instant};

kimchi/src/tests/xor.rs

@@ -22,7 +22,7 @@ use mina_poseidon::{
 use num_bigint::BigUint;
 use o1_utils::{BigUintHelpers, BitwiseOps, FieldHelpers, RandomField};
 use poly_commitment::{
-    evaluation_proof::{endos, OpeningProof, SRS},
+    ipa::{endos, OpeningProof, SRS},
     SRS as _,
 };
 

msm/src/prover.rs

@@ -29,7 +29,7 @@ use mina_poseidon::{sponge::ScalarChallenge, FqSponge};
 use o1_utils::ExtendedDensePolynomial;
 use poly_commitment::{
     commitment::{absorb_commitment, PolyComm},
-    evaluation_proof::DensePolynomialOrEvaluations,
+    ipa::DensePolynomialOrEvaluations,
     OpenProof, SRS,
 };
 use rand::{CryptoRng, RngCore};

o1vm/src/pickles/main.rs

@@ -11,7 +11,7 @@ use o1vm::{
     pickles::proof::ProofInputs,
     preimage_oracle::PreImageOracle,
 };
-use poly_commitment::{evaluation_proof::SRS, SRS as _};
+use poly_commitment::{ipa::SRS, SRS as _};
 use std::{fs::File, io::BufReader, process::ExitCode};
 
 use mina_curves::pasta::{Fp, Vesta};

poly-commitment/README.md

@@ -5,7 +5,7 @@ This library offers implementations of different Polynomial Commitment Scheme
 
 Currently, the following polynomial commitment schemes are implemented:
 - [KZG10](./src/kzg.rs)
-- [Inner Product Argument](./src/commitment.rs)
+- [Inner Product Argument](./src/ipa.rs)
 
 The implementations are made initially to be compatible with Kimchi (a Plonk-ish
 variant with 15 wires and some custom gates) and to be used in the Mina

poly-commitment/src/kzg.rs

@@ -11,7 +11,7 @@
 
 use crate::{
     commitment::*,
-    evaluation_proof::{combine_polys, SRS},
+    ipa::{combine_polys, SRS},
     CommitmentError, PolynomialsToCombine, SRS as SRSTrait,
 };
 

poly-commitment/src/lib.rs

@@ -2,15 +2,18 @@ pub mod chunked;
 mod combine;
 pub mod commitment;
 pub mod error;
-pub mod evaluation_proof;
+
+/// Inner product argument
+pub mod ipa;
+/// KZG polynomial commitment scheme
 pub mod kzg;
 
 pub use commitment::PolyComm;
 
 use crate::{
     commitment::{BatchEvaluationProof, BlindedCommitment, CommitmentCurve},
     error::CommitmentError,
-    evaluation_proof::DensePolynomialOrEvaluations,
+    ipa::DensePolynomialOrEvaluations,
 };
 use ark_ec::AffineRepr;
 use ark_ff::UniformRand;

poly-commitment/tests/batch_15_wires.rs

@@ -12,7 +12,7 @@ use mina_poseidon::{
 use o1_utils::ExtendedDensePolynomial as _;
 use poly_commitment::{
     commitment::{combined_inner_product, BatchEvaluationProof, CommitmentCurve, Evaluation},
-    evaluation_proof::{DensePolynomialOrEvaluations, SRS},
+    ipa::{DensePolynomialOrEvaluations, SRS},
     SRS as _,
 };
 use rand::Rng;

poly-commitment/tests/commitment.rs

@@ -12,7 +12,7 @@ use poly_commitment::{
         combined_inner_product, BatchEvaluationProof, BlindedCommitment, CommitmentCurve,
         Evaluation, PolyComm,
     },
-    evaluation_proof::{DensePolynomialOrEvaluations, OpeningProof, SRS},
+    ipa::{DensePolynomialOrEvaluations, OpeningProof, SRS},
     SRS as _,
 };
 use rand::{CryptoRng, Rng, SeedableRng};

poly-commitment/tests/ipa_commitment.rs

@@ -15,7 +15,7 @@ use poly_commitment::{
         combine_evaluations, combined_inner_product, BatchEvaluationProof, CommitmentCurve,
         Evaluation,
     },
-    evaluation_proof::{DensePolynomialOrEvaluations, SRS},
+    ipa::{DensePolynomialOrEvaluations, SRS},
     PolyComm, SRS as _,
 };
 use rand::{rngs::StdRng, SeedableRng};

poly-commitment/tests/kzg.rs

@@ -8,7 +8,7 @@ use ark_poly::{
 use ark_serialize::{CanonicalDeserialize, CanonicalSerialize};
 use poly_commitment::{
     commitment::Evaluation,
-    evaluation_proof::{DensePolynomialOrEvaluations, SRS},
+    ipa::{DensePolynomialOrEvaluations, SRS},
     kzg::{KZGProof, PairingSRS},
     SRS as _,
 };

tools/kimchi-visu/src/lib.rs

@@ -13,7 +13,7 @@ use kimchi::{
     curve::KimchiCurve,
     prover_index::ProverIndex,
 };
-use poly_commitment::{commitment::CommitmentCurve, evaluation_proof::OpeningProof};
+use poly_commitment::{commitment::CommitmentCurve, ipa::OpeningProof};
 use serde::Serialize;
 use std::{
     collections::HashMap,