Skip to content

Commit

Permalink
Addressing review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
shimkiv committed Oct 22, 2024
1 parent 1b4c945 commit a339d26
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/o1vm-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ on:
"curves/**",
"poseidon/**",
"poly-commitment/",
"internal-tracing/**",
"srs/**",
"utils/**",
]
push:
branches:
Expand All @@ -27,6 +30,9 @@ on:
"curves/**",
"poseidon/**",
"poly-commitment/",
"internal-tracing/**",
"srs/**",
"utils/**",
]

env:
Expand Down
4 changes: 1 addition & 3 deletions o1vm/src/interpreters/mips/witness.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1286,9 +1286,7 @@ impl<Fp: Field, PreImageOracle: PreImageOracleT> Env<Fp, PreImageOracle> {
let insn = self.get_opcode().unwrap();

// Approximate instruction per seconds
let how_many_steps = (step as usize)
.checked_sub(start.step)
.unwrap_or_else(|| panic!("Step counter overflowed: {} - {}", step, start.step));
let how_many_steps = step as usize - start.step;

let ips = how_many_steps as f64 / elapsed.as_secs() as f64;

Expand Down

0 comments on commit a339d26

Please sign in to comment.