Skip to content

Commit

Permalink
Clippy: introducing clippy.toml
Browse files Browse the repository at this point in the history
And add support up to 8 arguments.
  • Loading branch information
dannywillems committed Oct 4, 2024
1 parent 5183447 commit e95a901
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
6 changes: 6 additions & 0 deletions clippy.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Default is 7. However, it seems to be arbitrary. Some protocols do require
# many parameters, like polynomial commitment scheme when we want to make an
# opening.
# Note that we should not use too much this threshold, and stay clean in the
# choice of our routine parameters.
too-many-arguments-threshold = 8
1 change: 0 additions & 1 deletion poly-commitment/src/ipa.rs
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,6 @@ impl<G: CommitmentCurve> SRS<G> {
/// - rng: used for blinders for the zk property
/// A slight modification to the original protocol is done
/// when absorbing the first prover message.
#[allow(clippy::too_many_arguments)]
#[allow(clippy::type_complexity)]
#[allow(clippy::many_single_char_names)]
pub fn open<EFqSponge, RNG, D: EvaluationDomain<G::ScalarField>>(
Expand Down
1 change: 0 additions & 1 deletion poly-commitment/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ pub trait OpenProof<G: CommitmentCurve>: Sized + Clone {
/// - `sponge`: Sponge used to coin and absorb values and simulate
/// non-interactivity using the Fiat-Shamir transformation.
/// - `rng`: a pseudo random number generator in case blinding is needed
#[allow(clippy::too_many_arguments)]
fn open<EFqSponge, RNG, D: EvaluationDomain<<G as AffineRepr>::ScalarField>>(
srs: &Self::SRS,
group_map: &<G as CommitmentCurve>::Map,
Expand Down

0 comments on commit e95a901

Please sign in to comment.