-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrabiata: prepare constraints for cross-terms computation #2702
Open
dannywillems
wants to merge
13
commits into
master
Choose a base branch
from
dw/mvpoly-arrabiata-convert-into
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c28b4d4
MVPoly: cross-terms computation of a combili of mvpoly
dannywillems 3c2334b
Arrabiata/main: add more future tasks to remind
dannywillems 3864abb
Arrabiata/Column: implement column to usize
dannywillems 687e400
Arrabiata/Column: support conversion of public inputs into usize
dannywillems 1e9e66c
Arrabiata/Constraints: integrate mvpoly to compute cross-terms
dannywillems d60a681
Arrabiata/Column: support conversion of public inputs into usize
dannywillems d3fe0ba
MVPoly: method to compute the cross terms of a list of polynomials
dannywillems cf76131
Arrabiata/Constraints: integrate mvpoly to compute cross-terms
dannywillems 28b4d66
Arrabiata/tests: remove old comment
dannywillems 98cdfd9
MVPoly/monomials: improve generation of random generation
dannywillems 44a3f08
MVPoly/PBT: remove a flaky test for multilinearity
dannywillems ba0fad3
MVPoly/utils: compute nested loop indices with an upper bound
dannywillems c23758f
MVPoly/Cross-terms: add PBT
dannywillems File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A way to make this test test thing would be to checked the cross term property
poly(a +r*b) = poly(a) + r^n poly(b) + \sum_i r^i cross_term_i(a,b)
Also a nit: I wouldn't call that an integration test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the reason "integration" is double quoted.