Arrabiata: introduce trait ArrabiataCurve to englobe all data a curve must implement to be used with Arrabiata #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dw/mvpoly-arrabiata-convert-into #2719 +/- ##
===================================================================
Coverage ? 72.54%
===================================================================
Files ? 248
Lines ? 57942
Branches ? 0
===================================================================
Hits ? 42032
Misses ? 15910
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dannywillems
force-pushed
the
dw/mvpoly-arrabiata-convert-into
branch
from
4b0fd17
to
1e9e66c
Compare
Replicating the idea of KimchiCurve.
dannywillems
force-pushed
the
dw/arrabiata-curve-trait
branch
from
bc7eeb2
to
a7524e7
Compare
|
|
||
| /// Represents additional information that a curve needs in order to be used | ||
| /// with Arrabiata. | ||
| pub trait ArrabiataCurve: CommitmentCurve + EndoCurve { |
There was a problem hiding this comment.
Is it necessarry to introduce another trait ?
I don't see anything that isn't in KimchiCurve
(Which is not a surprise, as both Kimchi and Arrabiata use a cycle of curve for plonk verification operations)
marcbeunardeau88
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.