Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm: implement a simple ELF loader #2741

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

dannywillems
Copy link
Member

This is only a first draft. In future PR, FIXME will be implemented.
It is mostly to start moving commits from the pull request #2727

This is only a first draft. In future PR, FIXME will be implemented.
It is mostly to start moving commits from the pull request
#2727
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 91.73554% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.71%. Comparing base (fd0e8b8) to head (9130939).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/elf_loader.rs 91.73% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
+ Coverage   73.67%   73.71%   +0.03%     
==========================================
  Files         248      249       +1     
  Lines       57745    57866     +121     
==========================================
+ Hits        42542    42654     +112     
- Misses      15203    15212       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from dw/simplify-types-o1vm to master November 1, 2024 20:44
@dannywillems
Copy link
Member Author

The stack pointer must be set to a different address. The loader decides where to locate the first address. With @svv232 we think about having two continuous array, one for the heap, and one for the stack. It would be a follow-up of #2042.

@dannywillems
Copy link
Member Author

I'm taking the responsibility to improve it in the near future.

@dannywillems dannywillems merged commit 103513f into master Nov 14, 2024
8 checks passed
@dannywillems dannywillems deleted the dw/simple-elf-loader branch November 14, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants