Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query saffron #2974

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

query saffron #2974

wants to merge 12 commits into from

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Jan 29, 2025

This work completes the query feature and includes PRs #2972 and #2975

The goal is to be able to query data which is stored in encoded form (as field elements), using the binary indices of the original data

NOTE: The first commit diff is large, the rest are aiming to refactor that commit so should be more manageable

  • Add a query interface to query field encoded data
  • Add tests, including edge cases
  • Move UserData arbitrary instance to utils

@martyall martyall marked this pull request as ready for review January 30, 2025 18:35
@martyall martyall requested a review from Fizzixnerd January 30, 2025 19:56
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 95.16908% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.93%. Comparing base (97ee9f7) to head (bd4a885).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
saffron/src/utils.rs 95.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2974      +/-   ##
==========================================
+ Coverage   76.87%   76.93%   +0.06%     
==========================================
  Files         262      262              
  Lines       61445    61614     +169     
==========================================
+ Hits        47234    47401     +167     
- Misses      14211    14213       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants