Arrabbiata: prepare the primitives to absorb the state after committing to it #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps include the application and the verification parts, i.e. the whole program. Therefore it is the "program state".
dannywillems
commented
Jan 30, 2025
| pub previous_hash: [u128; 2], | ||
| /// The digest of the last program state, including the cross-terms | ||
| /// commitments. | ||
| /// The value is a 128 bits value, to be absorbed to initialize the sponge |
There was a problem hiding this comment.
Not sure yet about this. I will see later. It is mostly to initialize the sponge state when absorbing the commitments to the state in the next PR.
There was a problem hiding this comment.
This has been changed here
Base automatically changed from
arrabbiata/use-curve-instead-of-field
to
master
January 30, 2025 16:50
marcbeunardeau88
approved these changes
Jan 30, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2983 +/- ##
==========================================
- Coverage 76.84% 76.80% -0.05%
==========================================
Files 261 261
Lines 61370 61404 +34
==========================================
- Hits 47161 47159 -2
- Misses 14209 14245 +36 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next one will be #2982