Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage-proof command to cli and e2e #2985

Merged

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Jan 30, 2025

Summary

This PR adds a cli command storage-proof to generate proofs that the provider has the whole data. This is meant to work with #2979 where the verify-storage-proof command is added

Changes

  • add command storage-proof to cli to generate storage proof backed by core code from Proof of Storage #2971
  • added HexString and StorageProof newtypes to unify/simplify reading/outputting binary data with cli commands
  • added command as part of e2e script flow

@martyall martyall changed the title Add storage-proof to cli and e2e Add storage-proof command to cli and e2e Jan 30, 2025
@martyall martyall marked this pull request as ready for review January 30, 2025 22:44
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 50 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (35a9470) to head (e99a6c9).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
saffron/src/main.rs 0.00% 38 Missing ⚠️
saffron/src/cli.rs 0.00% 11 Missing ⚠️
saffron/src/proof.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
- Coverage   76.92%   76.83%   -0.10%     
==========================================
  Files         262      262              
  Lines       61392    61483      +91     
==========================================
+ Hits        47228    47242      +14     
- Misses      14164    14241      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems merged commit 2a10dff into master Feb 3, 2025
12 of 13 checks passed
@dannywillems dannywillems deleted the martin/saffron-proof-of-storage-clean-e2e-part-1 branch February 3, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants