Investigate switching to UPU from UPF for class powers #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wutname1
added a commit
to Wutname1/SpartanUI
that referenced
this pull request
Nov 16, 2022
After testing on my druid and monk there does not seem to be any noticeable change in combo points updating speed oUF-wow/oUF#625
ls-
force-pushed
the
classpower-patch
branch
2 times, most recently
from
f28a83b to
a8838cd
Compare
Azilroka
added a commit
to tukui-org/ElvUI
that referenced
this pull request
Mar 7, 2023
ls-
force-pushed
the
classpower-patch
branch
2 times, most recently
from
e9a1db0 to
e90e33f
Compare
ls-
force-pushed
the
classpower-patch
branch
2 times, most recently
from
8f425dc to
5b672e1
Compare
ls-
force-pushed
the
classpower-patch
branch
3 times, most recently
from
e0df8db to
e2b813e
Compare
|
This should be good to go right? Haven't heard of any issues with it and it's been running smoothly in SpartanUI since the Nov 2022 commit. Also, Elv added it last March and it made it into their v13.28 release in mid-March 2023. |
|
Been using this in RealUI also for a while now |
|
Yeah, I've been using it in my UI for over a year now as well, that's why I keep bumping this branch 😅 |
Rainrider
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPF is a very spammy event, and using it for something like class powers feels like an overkill. They simply don't continuously regen like , let's say, rogue's Energy. The only reason why we use UPF is because it's been this way for over a decade at this point 😒
I'm not sure if there's any drawbacks to using UPU hence the name of the PR. I'll switch my own UI to UPU to gather as much feedback as possible from its users, but help from others is always welcome 😊