Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags: Fix threatcolor tag #674

Merged
merged 1 commit into from
Apr 2, 2024
Merged

tags: Fix threatcolor tag #674

merged 1 commit into from
Apr 2, 2024

Conversation

ls-
Copy link
Member

@ls- ls- commented Apr 2, 2024

GetThreatStatusColor no longer accepts nil. Before 10.2.6 it used to return the same colour data for nil and 0, see wiki. It also no longer accepts -1, but we don't use that.

Fixes #673.

@ls- ls- requested review from p3lim and Rainrider April 2, 2024 01:23
@ls- ls- self-assigned this Apr 2, 2024
@ls- ls- merged commit c872822 into master Apr 2, 2024
1 check passed
@ls- ls- deleted the tag-fix branch April 2, 2024 05:58
kodewdle added a commit to tukui-org/ElvUI that referenced this pull request Apr 20, 2024
Hendo72 added a commit to Hendo72/ElvUI that referenced this pull request Apr 26, 2024
commit 462703a
Author: Paweł Jastrzębski <[email protected]>
Date:   Wed Apr 24 23:14:01 2024 +0200

    Updated Crest DataText

commit fe2970a
Author: Simpy <[email protected]>
Date:   Mon Apr 22 16:24:39 2024 -0400

    can't use this on classic anymore

commit 0da6a29
Author: Eltreum <[email protected]>
Date:   Sun Apr 21 15:17:41 2024 -0300

    update ptBR locale (tukui-org#1199)

commit df355e0
Author: namreeb <[email protected]>
Date:   Sun Apr 21 08:17:23 2024 -1000

    Added workaround for direct heals not reported by client when HealComm is present (tukui-org#1198)

commit 57835e6
Author: Simpy <[email protected]>
Date:   Sat Apr 20 18:19:15 2024 -0400

    oUF-wow/oUF#677

commit 6a9e514
Author: Simpy <[email protected]>
Date:   Sat Apr 20 18:14:34 2024 -0400

    oUF-wow/oUF#675

commit c202dbe
Author: Simpy <[email protected]>
Date:   Sat Apr 20 18:13:29 2024 -0400

    oUF-wow/oUF#674

commit f309445
Author: Simpy <[email protected]>
Date:   Sat Apr 20 17:54:49 2024 -0400

    fix interrupt msg for a832617

commit 8bc196f
Author: Simpy <[email protected]>
Date:   Sat Apr 20 17:20:49 2024 -0400

    dont need to translate

commit a832617
Author: anon1231823 <[email protected]>
Date:   Sat Apr 20 17:19:57 2024 -0400

    Update esMX.lua (tukui-org#1197)

commit 775f502
Author: Simpy <[email protected]>
Date:   Sat Apr 20 16:40:01 2024 -0400

    prefer C functions first

commit 1b4bab7
Author: Simpy <[email protected]>
Date:   Sat Apr 20 16:33:27 2024 -0400

    deprecated stuff

commit 205a5d2
Author: Simpy <[email protected]>
Date:   Sat Apr 20 15:53:55 2024 -0400

    move this

commit 8ea6f2f
Author: Simpy <[email protected]>
Date:   Sat Apr 20 15:49:16 2024 -0400

    testing func

commit e6e09d4
Author: Simpy <[email protected]>
Date:   Sat Apr 20 15:42:07 2024 -0400

    update blizz addon list

commit e6d9c23
Author: Simpy <[email protected]>
Date:   Tue Apr 16 21:12:08 2024 -0400

    add sunken temple difficulty id

commit d798dad
Author: Simpy <[email protected]>
Date:   Tue Apr 16 20:54:01 2024 -0400

    handle this another way

commit 857670c
Author: Luckyone <[email protected]>
Date:   Sun Apr 14 16:01:22 2024 +0200

    RaidBuffs: Sunken Temple 20man

commit c6f5ee2
Author: Luckyone <[email protected]>
Date:   Sun Apr 14 16:01:13 2024 +0200

    RaidDebuffs: Sunken Temple 20man

commit 5d0ddcb
Author: Darth Predator <[email protected]>
Date:   Sun Apr 14 02:55:18 2024 +0300

    Locales and stuff

commit 4f115b0
Author: Simpy <[email protected]>
Date:   Sat Apr 13 18:34:31 2024 -0400

    meow

commit 227aeda
Author: Simpy <[email protected]>
Date:   Sat Apr 13 18:09:45 2024 -0400

    think this is only broke on retail, others might double click otherwise

commit ea73e68
Author: Simpy <[email protected]>
Date:   Sat Apr 13 17:59:02 2024 -0400

    more accurate function name

commit b37261c
Author: Simpy <[email protected]>
Date:   Sat Apr 13 17:55:38 2024 -0400

    huh

commit 409d6dd
Author: Simpy <[email protected]>
Date:   Sat Apr 13 17:54:05 2024 -0400

    still false

commit c20d4df
Author: Simpy <[email protected]>
Date:   Sat Apr 13 17:47:02 2024 -0400

    update raid utility to work regardless of having leader/assist

commit f38ee28
Author: Repooc <[email protected]>
Date:   Sat Apr 13 16:06:50 2024 -0400

    update repooc's text

commit 9515250
Author: Simpy <[email protected]>
Date:   Sat Apr 13 14:12:19 2024 -0400

    pull char skin update from cata branch

commit 19d5eea
Author: Simpy <[email protected]>
Date:   Tue Apr 9 20:35:53 2024 -0400

    locales

commit e13ba2e
Author: Simpy <[email protected]>
Date:   Tue Apr 9 20:20:55 2024 -0400

    option to show high threat but not as primary target

commit 769260d
Author: Simpy <[email protected]>
Date:   Tue Apr 9 19:40:45 2024 -0400

    option to handle tukui-org#1187

commit 0a5c87f
Author: Simpy <[email protected]>
Date:   Tue Apr 9 19:36:27 2024 -0400

    new tag [threat:lead]

commit c0bb3f0
Author: Simpy <[email protected]>
Date:   Tue Apr 9 15:00:29 2024 -0400

    locales for the new option

commit 9bb41fe
Author: Simpy <[email protected]>
Date:   Tue Apr 9 14:53:47 2024 -0400

    retail changes from cata branch

commit 927ab2b
Author: Simpy <[email protected]>
Date:   Tue Apr 9 14:51:47 2024 -0400

    aura indicator override for pets (can uncheck Pet Specific to use profile or global)

commit e68e20d
Author: Simpy <[email protected]>
Date:   Sun Apr 7 19:15:03 2024 -0400

    bump minor version

commit b5c4ede
Author: Simpy <[email protected]>
Date:   Sun Apr 7 19:14:17 2024 -0400

    clean up some DT format

commit 8653c55
Author: Simpy <[email protected]>
Date:   Sun Apr 7 18:36:02 2024 -0400

    note for c6c5db5

commit c6c5db5
Author: Simpy <[email protected]>
Date:   Sun Apr 7 18:34:06 2024 -0400

    fix Range Check by using names again unless it's special

commit 87ba151
Author: Simpy <[email protected]>
Date:   Sun Apr 7 16:08:10 2024 -0400

    Revert "fix range check not working when you load in with spell ranks off (this uses the same method we use in  LibDispel)"

    This reverts commit 6a9205d.

commit 8522f97
Author: Simpy <[email protected]>
Date:   Sun Apr 7 15:04:00 2024 -0400

    it's SoD specific, whoops

commit 4d3d11e
Author: Simpy <[email protected]>
Date:   Sun Apr 7 14:48:53 2024 -0400

    update dualspec lua

commit d4a36bd
Author: Simpy <[email protected]>
Date:   Sun Apr 7 14:46:06 2024 -0400

    move DualSpec DT to Core since it's no longer for Wrath only

commit 6a9205d
Author: Simpy <[email protected]>
Date:   Sun Apr 7 14:42:44 2024 -0400

    fix range check not working when you load in with spell ranks off (this uses the same method we use in  LibDispel)

commit 467f032
Merge: 5248e24 1ea2165
Author: Repooc <[email protected]>
Date:   Thu Apr 4 12:47:54 2024 -0400

    Merge branch 'main' of https://github.com/tukui-org/ElvUI

commit 5248e24
Author: Repooc <[email protected]>
Date:   Thu Apr 4 12:47:42 2024 -0400

    min width set to 15 instead of 40 now per request from Jiberish

commit 1ea2165
Author: Luckyone <[email protected]>
Date:   Thu Apr 4 14:49:21 2024 +0200

    Load DualSpec DT for SoD

commit ffff65f
Author: Simpy <[email protected]>
Date:   Wed Apr 3 15:51:54 2024 -0400

    CHAT_MSG_GUILD_DEATHS was removed

commit a9d6198
Author: Simpy <[email protected]>
Date:   Wed Apr 3 14:53:33 2024 -0400

    priest paging on classic

commit 7e93f36
Author: Luckyone <[email protected]>
Date:   Wed Apr 3 12:53:06 2024 +0200

    Fix lib not loading

commit 588e246
Author: Luckyone <[email protected]>
Date:   Wed Apr 3 12:33:59 2024 +0200

    Lib is updated, testing now

commit df463ad
Author: Simpy <[email protected]>
Date:   Tue Apr 2 22:05:43 2024 -0400

    hUh

commit 24022ee
Author: Simpy <[email protected]>
Date:   Tue Apr 2 21:55:08 2024 -0400

    13.61

commit 179e613
Author: Simpy <[email protected]>
Date:   Tue Apr 2 21:28:17 2024 -0400

    cant do this with the lib outdated

commit 0e48785
Author: Luckyone <[email protected]>
Date:   Tue Apr 2 21:48:49 2024 +0200

    Added Mind Sear ChannelTicks

commit 83c4b6a
Author: Luckyone <[email protected]>
Date:   Tue Apr 2 21:48:31 2024 +0200

    Updated STV Event Auras

commit f2ed2ca
Author: Simpy <[email protected]>
Date:   Tue Apr 2 11:44:10 2024 -0400

    dual spec for SOD

commit f29d02c
Author: Luckyone <[email protected]>
Date:   Tue Apr 2 14:47:14 2024 +0200

    Updated Seasonal Toons

commit c5dbf4c
Author: Merathilis <[email protected]>
Date:   Tue Apr 2 12:23:11 2024 +0200

    Updated some of my toon

commit 17dd243
Author: Simpy <[email protected]>
Date:   Mon Apr 1 16:01:16 2024 -0400

    fix afk/dnd on chat

commit fc75691
Author: Luckyone <[email protected]>
Date:   Mon Apr 1 16:09:51 2024 +0200

    Updated Skins\PerksProgram

commit b39f4af
Author: Merathilis <[email protected]>
Date:   Mon Apr 1 12:34:10 2024 +0200

    Updated the Monthly Activities on the EncounterJournal Skin

commit 0f9d6b5
Author: Paweł Jastrzębski <[email protected]>
Date:   Sun Mar 31 10:21:34 2024 +0200

    Packager cleanup

commit 4d87ca0
Author: Simpy <[email protected]>
Date:   Sun Mar 31 02:40:30 2024 -0400

    revert this part

commit 725f98e
Author: Simpy <[email protected]>
Date:   Sun Mar 31 01:47:35 2024 -0400

    no point to strfind this its gonna be the same

commit 18b599c
Author: Simpy <[email protected]>
Date:   Sat Mar 30 20:19:55 2024 -0400

    git one as well

commit 67d3908
Author: Simpy <[email protected]>
Date:   Sat Mar 30 19:36:05 2024 -0400

    reimplement version check to dev builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using tags.Methods["threatcolor"](unit) breaks frequently on 10.2.6
2 participants