-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] TWW Support #678
Merged
+269
−114
Merged
[WIP] TWW Support #678
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2f69f2a
health: Add temp max health loss sub-widget
ls- 6d9f462
grouproleindicator: Update API
ls- 95c244a
range: Use events to drive updates
ls- 441c3f8
healthprediction: Add optional element size adjustment
ls- b4ec20f
Make linter happy
ls- 9d2853f
powerprediction: Update API
ls- cc254bd
health: Keep max hp reduction event registered
ls- 40fc8ae
healthprediction: Use legit events
ls- b498fad
healthprediction: Remove dynamic size adjustment
ls- d8b4df8
healthprediction: Add dynamic size adjustment
ls- 1b749ac
Point links to warcraft.wiki.gg
p3lim ee21f06
colors: Use provided enum
p3lim 2c3f13a
auras: Link directly to symbol
p3lim 317a89e
classpower: Update docs to match implementation
p3lim 1c88a01
Update source comments
p3lim 12fc45a
colors: We like fallback values
p3lim 17c4399
core: Only update visible eventless frames
ls- 07e3f10
powerprediction: Add dynamic size adjustment
ls- 806f70a
healthprediction: Add missing docs
ls- add83a0
health: Update docs
ls- 373b856
healthprediction: Add showRawAbsorb option
ls- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,18 +22,18 @@ A default texture will be applied if the widget is a StatusBar and doesn't have | |
The following options are listed by priority. The first check that returns true decides the color of the bar. | ||
|
||
.colorThreat - Use `self.colors.threat[threat]` to color the bar based on the unit's threat status. `threat` is | ||
defined by the first return of [UnitThreatSituation](https://wow.gamepedia.com/API_UnitThreatSituation) (boolean) | ||
defined by the first return of [UnitThreatSituation](https://warcraft.wiki.gg/wiki/API_UnitThreatSituation) (boolean) | ||
.colorPower - Use `self.colors.power[token]` to color the bar based on the unit's alternative power type | ||
(boolean) | ||
.colorClass - Use `self.colors.class[class]` to color the bar based on unit class. `class` is defined by the | ||
second return of [UnitClass](http://wowprogramming.com/docs/api/UnitClass.html) (boolean) | ||
second return of [UnitClass](https://warcraft.wiki.gg/wiki/API_UnitClass) (boolean) | ||
.colorClassNPC - Use `self.colors.class[class]` to color the bar if the unit is a NPC (boolean) | ||
.colorSelection - Use `self.colors.selection[selection]` to color the bar based on the unit's selection color. | ||
`selection` is defined by the return value of Private.unitSelectionType, a wrapper function | ||
for [UnitSelectionType](https://wow.gamepedia.com/API_UnitSelectionType) (boolean) | ||
for [UnitSelectionType](https://warcraft.wiki.gg/wiki/API_UnitSelectionType) (boolean) | ||
.colorReaction - Use `self.colors.reaction[reaction]` to color the bar based on the player's reaction towards the | ||
unit. `reaction` is defined by the return value of | ||
[UnitReaction](http://wowprogramming.com/docs/api/UnitReaction.html) (boolean) | ||
[UnitReaction](https://warcraft.wiki.gg/wiki/API_UnitReaction) (boolean) | ||
.colorSmooth - Use `self.colors.smooth` to color the bar with a smooth gradient based on the unit's current | ||
alternative power percentage (boolean) | ||
|
||
|
@@ -56,8 +56,9 @@ local Private = oUF.Private | |
|
||
local unitSelectionType = Private.unitSelectionType | ||
|
||
-- sourced from FrameXML/UnitPowerBarAlt.lua | ||
-- sourced from Blizzard_UnitFrame/UnitPowerBarAlt.lua | ||
local ALTERNATE_POWER_INDEX = Enum.PowerType.Alternate or 10 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And here? |
||
local ALTERNATE_POWER_NAME = 'ALTERNATE' | ||
|
||
local function updateTooltip(self) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ Handles the visibility and updating of the player's class resources (like Chi Or | |
|
||
## Widget | ||
|
||
ClassPower - An `table` consisting of as many StatusBars as the theoretical maximum return of [UnitPowerMax](http://wowprogramming.com/docs/api/UnitPowerMax.html). | ||
ClassPower - An `table` consisting of as many StatusBars as the theoretical maximum return of [UnitPowerMax](https://warcraft.wiki.gg/wiki/API_UnitPowerMax). | ||
|
||
## Sub-Widgets | ||
|
||
|
@@ -22,6 +22,7 @@ If the sub-widgets are StatusBars, their minimum and maximum values will be set | |
|
||
Supported class powers: | ||
- All - Combo Points | ||
- Evoker - Essence | ||
- Mage - Arcane Charges | ||
- Monk - Chi Orbs | ||
- Paladin - Holy Power | ||
|
@@ -49,10 +50,11 @@ local oUF = ns.oUF | |
|
||
local _, PlayerClass = UnitClass('player') | ||
|
||
-- sourced from FrameXML/Constants.lua | ||
-- sourced from Blizzard_FrameXMLBase/Constants.lua | ||
local SPEC_MAGE_ARCANE = _G.SPEC_MAGE_ARCANE or 1 | ||
local SPEC_MONK_WINDWALKER = _G.SPEC_MONK_WINDWALKER or 3 | ||
local SPEC_WARLOCK_DESTRUCTION = _G.SPEC_WARLOCK_DESTRUCTION or 3 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And here? |
||
local SPELL_POWER_ENERGY = Enum.PowerType.Energy or 3 | ||
local SPELL_POWER_COMBO_POINTS = Enum.PowerType.ComboPoints or 4 | ||
local SPELL_POWER_SOUL_SHARDS = Enum.PowerType.SoulShards or 7 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here?