-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples for JDK 21 (Android Studio Ladybug) #695
base: main
Are you sure you want to change the base?
Conversation
ce7524d
to
f29e1ac
Compare
At least Flutter SDK 3.7.12: This matches what can be built by CI due to dependency constraints, so is the lowest version users could possibly be using. At least Flutter SDK 3.13.9: required to upgrade to Android Gradle Plugin 8.2.1 (to support JDK 21) which requires using the namespace property. At least Flutter SDK 3.16.9: required to apply Flutter plugin using plugins block, which is required to do further changes to support JDK 21.
…objectbox-dart#127
…ox-dart#127 To match the lowest supported version by examples.
b5a33c5
to
a467973
Compare
Also improve help output if run without arguments.
2f03936
to
2dd62a3
Compare
2dd62a3
to
ecb998c
Compare
Would this PR make the warnings below that objectbox currently give me disappear? |
@hagerf No, it won't. Thanks for reporting! This warning occurs due to using JDK 21 to compile. But we can make changes to the Flutter plugins to suppress it, made an internal note about that ( If it bothers you, you can try to suppress the warning yourself. You likely need to add something like below to the relevant Gradle script in the
Long term we need to use the Java 11 level to compile (Flutter appears to also prepare for that), but that has other complications (like a higher minimum supported Android SDK level). |
Thanks for the quick and detailed answer! |
As part of this change I plan to suppress the warnings. And no, there is currently only an internal task to update to Java 11 level once it makes sense. |
Public PR to run GitHub Actions.