Skip to content

Commit

Permalink
refactor(#2579): todo
Browse files Browse the repository at this point in the history
  • Loading branch information
@Yanich96
Yanich96 committed Nov 28, 2023
1 parent 371b89d commit b0532d4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions eo-maven-plugin/src/main/java/org/eolang/maven/ShakeMojo.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@
/**
* Shake (prepare) XML files after optimizations for translation to java.
*
* @todo #2577:30min Resolve code duplication between {@link OptimizeMojo} and {@link ShakeMojo}.
* ShakeMojo was created in order to split two optimization stages: optimizations themselves and
* preparations for translation to java. Now these two mojo look almost the same and there's a lot
* of code duplication. So it's needed to resolve that. Don't forget to remove the puzzle
* @todo #2577:30min Add tests for ShakeMojo. ShakeMojo was created in order to split two
* optimization stages: optimizations themselves and preparations for translation to java
* Need to create tests for {@link ShakeMojo} in order to be sure that it does only it's job.
Expand Down

3 comments on commit b0532d4

@0pdd
Copy link

@0pdd 0pdd commented on b0532d4 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 2577-b57ee58e disappeared from eo-maven-plugin/src/main/java/org/eolang/maven/ShakeMojo.java), that's why I closed #2579. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on b0532d4 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 2577-d3715d46 disappeared from eo-maven-plugin/src/main/java/org/eolang/maven/ShakeMojo.java), that's why I closed #2580. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on b0532d4 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 2577-73df16a8 discovered in eo-maven-plugin/src/main/java/org/eolang/maven/ShakeMojo.java) and submitted as #2638. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.