better logging for lint errors

objectionary · Dec 17, 2024 · ee548da · ee548da
1 parent 1d1bdf5
commit ee548da
Showing 1 changed file with 16 additions and 13 deletions.
diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/LintMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/LintMojo.java
@@ -104,21 +104,24 @@ void exec() throws IOException {
             this.lintAll(counts)
         );
         final String sum = LintMojo.summary(counts);
-        if (counts.get(Severity.ERROR) > 0 || counts.get(Severity.CRITICAL) > 0
-            || counts.get(Severity.WARNING) > 0 && this.failOnWarning) {
-            Logger.info(
-                this,
-                "Linted %d out of %d XMIR program(s) that needed this (out of %d total programs): %s",
-                passed, tojos.size(), tojos.size(), sum
-            );
+        Logger.info(
+            this,
+            "Linted %d out of %d XMIR program(s) that needed this (out of %d total programs): %s",
+            passed, tojos.size(), tojos.size(), sum
+        );
+        if (counts.get(Severity.ERROR) > 0 || counts.get(Severity.CRITICAL) > 0) {
             throw new IllegalStateException(
-                String.format("In %d XMIR files, we found %s", tojos.size(), sum)
+                String.format(
+                    "In %d XMIR files, we found %s (must stop here)",
+                    tojos.size(), sum
+                )
             );
-        } else {
-            Logger.info(
-                this,
-                "Linted %d out of %d XMIR program(s) that needed this: %s",
-                passed, tojos.size(), sum
+        } else if (counts.get(Severity.WARNING) > 0 && this.failOnWarning) {
+            throw new IllegalStateException(
+                String.format(
+                    "In %d XMIR files, we found %s (use -Deo.failOnWarning=false to ignore)",
+                    tojos.size(), sum
+                )
             );
         }
     }