Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2764): new tasks for the correct operation of the cache #2783

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

Yanich96
Copy link
Contributor

@Yanich96 Yanich96 commented Jan 16, 2024

Closes: #2764
The solution was made in which we continue to use the modification time of files without using file internal components. Hash code isn't needed.


PR-Codex overview

This PR focuses on fixing the caching mechanism in OptCached and unifying the caching mechanism on different stages.

Detailed summary

  • Changed the @todo comment to use checksum instead of time for file validation from cache.
  • Added a new @todo comment to unify the caching mechanism on different stages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Yanich96
Copy link
Contributor Author

@volodya-lombrozo check please.
My old changes are not needed. You need to solve the cache problem in a different way.

Copy link
Member

@volodya-lombrozo volodya-lombrozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yanich96 Looks good to me

@Yanich96
Copy link
Contributor Author

@yegor256 please merge

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jan 17, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 036be9f into objectionary:master Jan 17, 2024
12 checks passed
@rultor
Copy link
Contributor

rultor commented Jan 17, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptCached.java:44-49: Use checksum, not time. The...
4 participants