3139 rust projects names #3157
Merged
3139 rust projects names #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon WDYT |
maxonfjvipon
requested changes
Apr 28, 2024
| private static String translate(final String clazz, final String method) { | ||
| return String.format( | ||
| "Java_%s_%s", | ||
| clazz.replace("_", "_1").replace(".", "_"), |
There was a problem hiding this comment.
@levBagryansky I didn't get what is "_1" for
There was a problem hiding this comment.
@maxonfjvipon There are 2 refs in commentary: https://stackoverflow.com/questions/32470463/what-is-the-naming-convention-for-java-native-interface-method-and-module-name">stackoverflow
Or, according to oracle spec:
| Escape Sequence | Denotes |
|---|---|
| _1 | the character “_” |
| _2 | the character “;” in signature |
| _3 | the character “[“ in signatures |
In our case we have "_" only
| @@ -58,4 +58,32 @@ public PrimeModule(final String method, final String file) { | |||
| file | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Translates ("mangles") Java method name to native method name. | |||
There was a problem hiding this comment.
@levBagryansky let's add an example to the doc. Something like "before -> after"
|
@maxonfjvipon please check |
maxonfjvipon
approved these changes
May 2, 2024
|
@yegor256 please check |
|
@rultor merge |
@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 22min) |
|
@yegor256 please merge |
|
@yegor256 please check |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3139
PR-Codex overview
This PR enhances the Rust integration in the Maven plugin by updating file paths, adding a Rust function, and improving naming conventions.
Detailed summary