#3239: BytesOf refactoring #3259
Conversation
|
@c71n93 please approve |
| * @todo #3239:90min Method {@link BytesOf#shift} should be refactored to get rid of | ||
| * {@code @SuppressWarnings("PMD.CognitiveComplexity")} warning. You can | ||
| * check description of this rules here | ||
| * <a href="https://pmd.github.io/pmd/pmd_rules_java_design">pmd.github.io</a> |
There was a problem hiding this comment.
@levBagryansky Since this todo now related only to shift method, you can move todo closer to it.
There was a problem hiding this comment.
@c71n93 I cannot, Override methods does not have commentary
There was a problem hiding this comment.
@levBagryansky one moment, why BytesRaw is no longer a "GodClass"? I don't see any differences between old BytesOf class and current BytesRaw.
@levBagryansky never mind, I figured out. |
|
@c71n93 please approve |
|
@yegor256 please take a look |
|
@yegor256 please check |
1 similar comment
|
@yegor256 please check |
|
@rultor merge |
@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 42min) |
|
@yegor256 let's try again, looks like something with rultor here |
|
@levBagryansky thanks! |
|
@c71n93 Thanks for the review! You've earned +72 points for this (+25 as a basis, +40 for 433 hits-of-code, +7 for 7 comments). |
|
@levBagryansky Thanks for the contribution! You've earned +47 points for this (+20 as a basis, +40 for 433 hits-of-code, -13 for 13 comments). Please, keep them coming. |
Closes #3239
Now
BytesOfkeeps functionality of both genericctorand methods' implementation. I transferred methods' implementation to separate classBytesRawPR-Codex overview
The focus of this PR is to refactor the
BytesOfclass by introducing a newBytesRawclass and updating the constructor and method implementations.Detailed summary
BytesRawclass for byte array operationsBytesOfclass constructor and methods to useBytesRaw