Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): added sprintf and list to eo-runtime #3261

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jul 10, 2024

Ref: #3251


PR-Codex overview

This PR updates package names, adds new objects, and includes licensing info.

Detailed summary

  • Renamed EOorg.EOeolang.EOio to EOorg.EOeolang.EOtxt
  • Added @XmirObject annotations
  • Updated exclusion paths in codacy.yml
  • Modified toPhi method in Data.java
  • Updated licensing info in package-info files

The following files were skipped due to too many changes: eo-runtime/src/test/java/EOorg/EOeolang/EOtxt/EOsprintfTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EOtxt/EOsprintf.java, eo-runtime/src/main/eo/org/eolang/structs/list.eo, eo-runtime/src/test/eo/org/eolang/structs/list-tests.eo

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 11, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 11, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 18min)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 11, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 11, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 41min)

@yegor256 yegor256 merged commit 7763335 into objectionary:master Jul 11, 2024
22 checks passed
@0crat
Copy link

0crat commented Jul 11, 2024

@yegor256 Thanks for the review! You've earned +72 points for this (+25 as a basis, +40 for 1301 hits-of-code, +7 for 7 comments). Your running balance is +25.

@0crat
Copy link

0crat commented Jul 11, 2024

@maxonfjvipon Thanks for the contribution! You've earned +53 points for this (+20 as a basis, +40 for 1301 hits-of-code, -7 for 7 comments). Please, keep them coming. Your running balance is +60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants