Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#3283): replaced float and int with number #3289

Merged
merged 4 commits into from
Jul 26, 2024
Merged

feat(#3283): replaced float and int with number #3289

merged 4 commits into from
Jul 26, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jul 25, 2024 •
edited by pr-codex bot
Loading

Closes: #3283

PR-Codex overview

This PR updates the codebase to replace int with number for improved type consistency and precision.

Detailed summary

  • Replaced int with number for type consistency
  • Updated method names for clarity
  • Improved error handling and test coverage
  • Enhanced code readability and maintainability

The following files were skipped due to too many changes: eo-runtime/src/main/eo/org/eolang/txt/sscanf.eo, eo-maven-plugin/src/main/resources/org/eolang/maven/pre/to-java.xsl, eo-parser/src/test/resources/org/eolang/parser/packs/syntax/post-method.yaml, eo-runtime/src/test/eo/org/eolang/dataized-tests.eo, eo-maven-plugin/src/test/resources/org/eolang/maven/sodgs/data.yaml, eo-parser/src/test/resources/org/eolang/parser/packs/syntax/bound-reversed-application.yaml, eo-runtime/src/test/java/org/eolang/PhCopyTest.java, eo-parser/src/test/resources/org/eolang/parser/packs/parsed-data.yaml, eo-runtime/src/test/java/org/eolang/PhiTest.java, eo-runtime/src/test/java/org/eolang/DataizedTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EOio/EOstdout.java, eo-runtime/src/test/java/org/eolang/BytesOfTest.java, eo-maven-plugin/src/test/resources/org/eolang/maven/packs/test-object-to-java.yaml, eo-maven-plugin/src/test/resources/org/eolang/maven/sodgs/dots.yaml, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOeq.java, eo-maven-plugin/src/test/resources/org/eolang/maven/sodgs/abstracts.yaml, eo-parser/src/test/java/org/eolang/parser/EoSyntaxTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOnot.java, eo-runtime/src/main/java/org/eolang/BytesRaw.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOsize.java, eo-maven-plugin/src/test/resources/org/eolang/maven/sodgs/arrays.yaml, eo-parser/src/test/resources/org/eolang/parser/packs/optimize/redundant-levels-with-siblings.yaml, eo-runtime/src/test/java/EOorg/EOeolang/EOtryTest.java, eo-parser/src/test/resources/org/eolang/parser/packs/optimize/redundant-levels.yaml, .codacy.yml, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOor.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOand.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOxor.java, eo-maven-plugin/src/test/resources/org/eolang/maven/phi/yaml/fibonaci.yaml, eo-maven-plugin/src/test/resources/org/eolang/maven/binarize/twice-rust.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EOencaged$EOencage.java, eo-runtime/src/main/java/org/eolang/Data.java, eo-runtime/src/main/rust/eo/src/eo_enum.rs, eo-runtime/src/test/java/org/eolang/PhPackageTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOright.java, eo-runtime/src/main/java/EOorg/EOeolang/EOstring$EOlength.java, /eo-runtime/src/main/java/EOorg/EOeolang/EOcage$EOencaged$EO\317\206.java", eo-runtime/src/test/java/EOorg/EOeolang/EOmallocTest.java, eo-runtime/src/test/java/org/eolang/UniverseDefaultTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EOmalloc$EOof$EOallocated$EOwrite.java, eo-runtime/src/test/java/EOorg/EOeolang/EOio/EOstdoutTest.java, eo-runtime/src/test/eo/org/eolang/seq-tests.eo, eo-runtime/src/test/eo/org/eolang/int-tests.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOtxt/EOregex$EOcompiled.java, eo-runtime/src/main/eo/org/eolang/structs/list.eo, eo-parser/src/test/resources/org/eolang/parser/packs/add-locators.yaml, eo-runtime/src/main/eo/org/eolang/structs/hash-code-of.eo, eo-runtime/src/test/java/org/eolang/SnippetTestCase.java, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOconcat.java, eo-parser/src/main/java/org/eolang/parser/XeEoListener.java, eo-runtime/src/main/eo/org/eolang/bytes.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOmalloc$EOof$EOallocated$EOread.java, eo-maven-plugin/src/test/java/org/eolang/maven/BinarizeParseTest.java, eo-runtime/src/test/java/EOorg/EOeolang/EOintTest.java, eo-runtime/src/test/java/org/eolang/PhWithTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EOstring$EOslice.java, eo-runtime/src/test/eo/org/eolang/runtime-tests.eo, eo-runtime/src/test/eo/org/eolang/while-tests.eo, eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOslice.java, eo-runtime/src/main/java/EOorg/EOeolang/EOint$EOgt.java, eo-runtime/src/main/java/EOorg/EOeolang/EOint$EOtimes.java, eo-runtime/src/test/eo/org/eolang/cage-tests.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOtimes.java, eo-maven-plugin/src/test/resources/org/eolang/maven/packs/data-as-bytes.yaml, eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOdiv.java, eo-maven-plugin/src/test/resources/org/eolang/maven/phi/yaml/iterates-over-counter.yaml, eo-runtime/src/main/java/EOorg/EOeolang/EOtxt/EOsscanf.java, eo-runtime/src/test/eo/org/eolang/txt/text-tests.eo, eo-parser/src/test/resources/org/eolang/parser/packs/syntax/tuples.yaml, eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOplus.java, eo-runtime/src/test/eo/org/eolang/structs/hash-code-of-tests.eo, eo-parser/src/main/java/org/eolang/parser/StUnhex.java, eo-parser/src/test/resources/org/eolang/parser/packs/explicit-data.yaml, eo-runtime/src/main/java/EOorg/EOeolang/EOtxt/EOsprintf.java, eo-parser/src/test/java/org/eolang/parser/StUnhexTest.java, eo-runtime/src/main/eo/org/eolang/txt/regex.eo, eo-runtime/src/main/eo/org/eolang/positive-infinity.eo, eo-runtime/src/main/eo/org/eolang/negative-infinity.eo, eo-runtime/src/main/eo/org/eolang/float.eo, eo-parser/src/test/resources/org/eolang/parser/packs/optimize/redundant-levels-with-arrays.yaml, eo-runtime/src/main/java/org/eolang/Dataized.java, eo-parser/src/main/resources/org/eolang/parser/explicit-data.xsl, eo-runtime/src/main/java/EOorg/EOeolang/EOtxt/EOregex$EOpattern$EOmatch$EOmatched_from_index.java, eo-parser/src/test/resources/org/eolang/parser/packs/all-data-types.yaml, eo-runtime/src/test/java/EOorg/EOeolang/EOcageTest.java, eo-runtime/src/test/java/org/eolang/PhDefaultTest.java, eo-runtime/src/test/eo/org/eolang/bytes-tests.eo, eo-runtime/src/main/eo/org/eolang/txt/text.eo, eo-runtime/src/test/java/EOorg/EOeolang/EOio/EOstdinTest.java, eo-runtime/src/test/eo/org/eolang/rust-tests.eo

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 25, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 25, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 26min)

    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/eo-runtime/target/surefire-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
    at org.apache.maven.plugin.surefire.SurefireHelper.throwException (SurefireHelper.java:247)
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution (SurefireHelper.java:159)
    at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary (SurefirePlugin.java:542)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked (AbstractSurefireMojo.java:1117)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute (AbstractSurefireMojo.java:939)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :eo-runtime
\u001b[0m\u001b[0mcontainer ad99cc67329c8556bea31df991d680aaa51cb07ed1aff7a09a3645f594044570 is dead
Thu Jul 25 14:52:58 UTC 2024

@maxonfjvipon
Copy link
Member Author

@yegor256 please try to merge one more time

@yegor256
Copy link
Member

@maxonfjvipon something is wrong with one test?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 47min)

@yegor256
Copy link
Member

@maxonfjvipon there is definitely something wrong with one test

@maxonfjvipon
Copy link
Member Author

@yegor256 let's try again, now we at least should see log on failed snippet test

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 46min)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 48min)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@maxonfjvipon
Copy link
Member Author

@rultor status

@rultor
Copy link
Contributor

rultor commented Jul 26, 2024

@rultor status

@maxonfjvipon This is what's going on here:

More information about Rultor commands you can get here.

@yegor256 yegor256 merged commit 28917b6 into objectionary:master Jul 26, 2024
22 checks passed
@yegor256
Copy link
Member

@maxonfjvipon let's make it simple this time

@0crat
Copy link

0crat commented Jul 26, 2024

@maxonfjvipon Thanks for the contribution! You've earned +5 points for this: +20 as a basis; +5 for 3226 hits-of-code; -7 for too many hits-of-code (3226 >= 100); -15 for way too many hits-of-code (3226 >= 400); -15 for the lack of code review; -20 for 21 comments of reviewers; +37 to give you at least something. Please, keep them coming. Your running balance is +118.

@rultor
Copy link
Contributor

rultor commented Jul 29, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 14s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 1400
+ echo '2.0-SNAPSHOT BUILD'
2.0-SNAPSHOT BUILD
+ date
Mon Jul 29 12:09:08 UTC 2024
+ uptime
 12:09:08 up 1 min,  0 users,  load average: 1.28, 0.39, 0.14
+ Failed to read profile: EC2 instance type t2.xlarge is not valid, use one of '[t2.nano,' t2.micro, t2.small, t2.medium, 't2.large]'
./run.sh: line 11: Failed: command not found
'cid' file is absent, most probably the Docker container wasn't started correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace int and float with number
4 participants
@maxonfjvipon @yegor256 @rultor @0crat