Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): move eo-files to eo-runtime #3309

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 1, 2024

Ref: #3251

What's done:

  • Introduced file object
  • Introduced dir object
  • Introduced tmpdir object
  • Introduced getenv object
  • Object uname is renamed to os
  • Fixed unescapedJavaString function so it works correctly

PR-Codex overview

This PR updates the project to use .typos.toml config file, renames classes, improves file structure, and refactors environment-related objects.

Detailed summary

  • Updated workflow to use .typos.toml config file
  • Renamed classes for consistency
  • Improved file structure in EOorg.EOeolang.EOfs package
  • Refactored environment-related objects for clarity

The following files were skipped due to too many changes: eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOsize.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOexists.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOis_directory.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOmade$EOmkdir.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOtouched$EOtouch.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOdeleted$EOdelete.java, eo-runtime/src/main/java/EOorg/EOeolang/EOsys/EOgetenv.java, .codacy.yml, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOresolved$EOresolve.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOmoved$EOmove.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOtmpfile$EOtouch.java, eo-runtime/src/test/java/EOorg/EOeolang/EOfs/EOfileTest.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOopen$EOprocess_file.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOopen$EOfile_stream$EOread$EOread_bytes.java, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOfile$EOopen$EOfile_stream$EOwrite$EOwritten_bytes.java, eo-runtime/src/main/eo/org/eolang/fs/tmpdir.eo, eo-runtime/src/test/eo/org/eolang/fs/dir-test.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOwalk.java, eo-runtime/src/main/eo/org/eolang/fs/dir.eo, eo-runtime/src/main/java/EOorg/EOeolang/EOfs/Files.java, eo-runtime/src/test/java/EOorg/EOeolang/EOfs/FilesTest.java, eo-runtime/src/test/eo/org/eolang/fs/file-tests.eo, eo-runtime/src/main/eo/org/eolang/fs/file.eo

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented Aug 2, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 2, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6a8fadc into objectionary:master Aug 2, 2024
22 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 2, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 27min)

@yegor256
Copy link
Member

yegor256 commented Aug 2, 2024

@maxonfjvipon very good job, thanks!

@0crat
Copy link

0crat commented Aug 2, 2024

@maxonfjvipon 🎉 Awesome job on your contribution! You've snagged 5 points this time. We love your enthusiasm, but remember: less code can be more effective. Next time, try to trim it down a bit and don't forget to get a code review. Keep those comments coming too! Your speed vs quality balance is crucial. Your total score is now a cool 200 points. Keep up the great work! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants