Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EO traces #3479

Merged
merged 6 commits into from
Nov 10, 2024
Merged

EO traces #3479

merged 6 commits into from
Nov 10, 2024

Conversation

yegor256
Copy link
Member

@yegor256 yegor256 commented Nov 10, 2024

See #3460

Now it should be possible to see the trace of EO object calls.


PR-Codex overview

This PR focuses on refactoring the lambda() methods across various classes in the eo-runtime project to remove the throws Exception declaration, enhancing exception handling, and improving the code's readability and maintainability.

Detailed summary

  • Removed throws Exception from multiple lambda() methods.
  • Updated exception handling to throw IllegalArgumentException with detailed messages.
  • Refactored lambda() implementations to improve readability.
  • Changed error handling to utilize PhSafe in several test cases.
  • Modified imports and test assertions to reflect class changes.
  • Enhanced PhNamed class to include error reporting for attributes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256 yegor256 marked this pull request as draft November 10, 2024 05:31
@yegor256 yegor256 marked this pull request as ready for review November 10, 2024 12:37
@yegor256 yegor256 merged commit b665298 into master Nov 10, 2024
20 checks passed
@yegor256 yegor256 deleted the 3460 branch November 10, 2024 12:47
@yegor256 yegor256 restored the 3460 branch November 10, 2024 12:47
@yegor256 yegor256 deleted the 3460 branch November 10, 2024 12:47
@0crat
Copy link

0crat commented Nov 24, 2024

@yegor256 Great job on your contribution! 🎉 You've earned +4 points for this effort. While there were some deductions for code size and review aspects, we appreciate your hard work. Your current balance stands at -46. Keep the momentum going and focus on quality in your next submissions. Looking forward to your future contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants