-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing profiles(solves invoker-maven-plugin invocation when -DskipITs is set) #3739
Conversation
@maxonfjvipon please, check this one |
@ArtemGet could you please also integrate these profiles into our CI builds (see |
|
@ArtemGet please, read this: https://www.yegor256.com/2024/04/01/ping-me-please.html |
@maxonfjvipon logs shows that all went fine. Invoker skipped at mvn, surefire skipped at integration and both did not run at qulice check. |
@yegor256 thanks, just did not want to bother before i make shure all job's logs is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArtemGet LGTM!
To achieve this logic I added profiles as I mentioned in comment.
Profile activates if corresponding property is set, so there are no need to rewrite any action scripts.
I.E:
-DskipTests -> -PskipTests
-DskipITs -> -PskipITs
-DskipUTs -> -PskipUTs
(-PskipITs and PskipUTs is kind of useless, but i added them to uniformity with -PskipTests)