fix(#3793): Fix Expect #3795
Merged
fix(#3793): Fix Expect #3795
+117
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmirnov-backend
force-pushed
the
fix/#3793/fix-expect
branch
from
8b7e6aa to
0b1ae1e
Compare
yegor256
reviewed
Jan 8, 2025
|
@asmirnov-backend looks very good! Please, make sure the build passes and then we'll review the PR. |
asmirnov-backend
force-pushed
the
fix/#3793/fix-expect
branch
from
d813949 to
21679bc
Compare
|
Errors in checks were fixed. @yegor256 Could you please review |
yegor256
reviewed
Jan 12, 2025
yegor256
reviewed
Jan 12, 2025
|
@asmirnov-backend looks very good now! A few small comments above |
|
@yegor256 Thank you for review and comments. I appreciate it. Fixed the code according to your comments. |
|
@maxonfjvipon please, review this one |
maxonfjvipon
approved these changes
Jan 12, 2025
|
@asmirnov-backend all conversations must be resolved and this PR will be merged automatically: please, resolve them |
|
@yegor256 @maxonfjvipon Thanks for review and help. I am happy that I was able to make contribution 😊 |
|
@asmirnov-backend thanks a lot! We are looking forward to more pull requests from you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3793
Now Expect is "fail fast" and the error message is only for one fail